Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make VideoFrame a CanvasImageSource #158

Closed
chcunningham opened this issue Mar 29, 2021 · 2 comments
Closed

Make VideoFrame a CanvasImageSource #158

chcunningham opened this issue Mar 29, 2021 · 2 comments
Milestone
V1 Launch Blockers

Comments

@chcunningham
Copy link
Collaborator

Already implemented in Chrome. This issue tracks the need to file a PR on HTML to get VideoFrame added here.

This makes it possible to use canvas drawImage(videoFrame) as well as window.createImageBitmap(videoFrame) (meaning we can remove videoFrame.createImageBitmap().

This is simpler to use and more efficient vs previous proposal of always first creating an ImageBitmap.

Related issues: #88 and #145
@chcunningham chcunningham mentioned this issue Mar 29, 2021
Closed
@chcunningham
Copy link
Collaborator Author

@domenic FYI

@chcunningham chcunningham mentioned this issue Mar 29, 2021
Closed
@chcunningham chcunningham added this to the 2021 Q1 milestone Mar 29, 2021
@dalecurtis
Copy link
Contributor

We also need to add it as a TexImageSource here: https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14 I was planning to get to it this week.

dalecurtis added a commit to dalecurtis/html that referenced this issue Apr 14, 2021
@dalecurtis
Add WebCodecs VideoFrame as CanvasImageSource.
40a5df4 
Bug: w3c/webcodecs#158
dalecurtis added a commit to dalecurtis/html that referenced this issue Apr 14, 2021
@dalecurtis
Add WebCodecs VideoFrame as CanvasImageSource.
30b2486 
Adding VideoFrame as a CanvasImageSource allows drawImage(),
createImageBitmap(), and texImage() to interoperate with VideoFrames.
VideoFrames are effectively the same as the existing point-in-time
capture done for HTMLVideoElement on each of these interfaces.

This adds a non-normative reference on the WebCodecs spec for the
VideoFrame interface and associated properties to accomplish this.

Bug: w3c/webcodecs#158
dalecurtis added a commit to dalecurtis/html that referenced this issue Apr 16, 2021
@dalecurtis
Add WebCodecs VideoFrame as CanvasImageSource.
4d6064c 
Adding VideoFrame as a CanvasImageSource allows drawImage(),
createImageBitmap(), and texImage() to interoperate with VideoFrames.
VideoFrames are effectively the same as the existing point-in-time
capture done for HTMLVideoElement on each of these interfaces.

This adds a non-normative reference on the WebCodecs spec for the
VideoFrame interface and associated properties to accomplish this.

Bug: w3c/webcodecs#158
@dalecurtis dalecurtis mentioned this issue Apr 16, 2021
Merged
@w3c w3c deleted a comment Apr 19, 2021
@chcunningham chcunningham mentioned this issue Apr 19, 2021
Merged
@dogben dogben mentioned this issue May 11, 2021
Open
dalecurtis added a commit to dalecurtis/WebGL that referenced this issue Jun 1, 2021
@dalecurtis
Add WebCodecs VideoFrame as a TexImageSource.
a092479 
Adding VideoFrame as a TexImageSource allows texImage*() methods to
interoperate with VideoFrames. VideoFrames work with texImage*() the
same way the existing point-in-time capture for HTMLVideoElement does.

This adds a non-normative reference on the WebCodecs spec for the
VideoFrame interface and associated properties to accomplish this.

Note: VideoFrame objects are always same-origin, so I did not add
any text around origin restrictions for video frames.

https://www.w3.org/TR/webcodecs/#videoframe-interface

Bug: w3c/webcodecs#158
@dalecurtis dalecurtis mentioned this issue Jun 1, 2021
Merged
kdashg pushed a commit to KhronosGroup/WebGL that referenced this issue Jun 3, 2021
@dalecurtis
Add WebCodecs VideoFrame as a TexImageSource. (#3288)
bd18b05 
* Add WebCodecs VideoFrame as a TexImageSource.

Adding VideoFrame as a TexImageSource allows texImage*() methods to
interoperate with VideoFrames. VideoFrames work with texImage*() the
same way the existing point-in-time capture for HTMLVideoElement does.

This adds a non-normative reference on the WebCodecs spec for the
VideoFrame interface and associated properties to accomplish this.

Note: VideoFrame objects are always same-origin, so I did not add
any text around origin restrictions for video frames.

https://www.w3.org/TR/webcodecs/#videoframe-interface

Bug: w3c/webcodecs#158

* Actually add spec reference.
dalecurtis added a commit to dalecurtis/html that referenced this issue Jul 19, 2021
@dalecurtis
Add WebCodecs VideoFrame as CanvasImageSource.
793fb9f 
Adding VideoFrame as a CanvasImageSource allows drawImage(),
createImageBitmap(), and texImage() to interoperate with VideoFrames.
VideoFrames are effectively the same as the existing point-in-time
capture done for HTMLVideoElement on each of these interfaces.

This adds a non-normative reference on the WebCodecs spec for the
VideoFrame interface and associated properties to accomplish this.

Bug: w3c/webcodecs#158
domenic pushed a commit to whatwg/html that referenced this issue Jul 29, 2021
@dalecurtis
Add WebCodecs VideoFrame as CanvasImageSource
57f3bb0 
Adding VideoFrame as a CanvasImageSource allows drawImage(), createImageBitmap(), and texImage() to interoperate with VideoFrames. VideoFrames are effectively the same as the existing point-in-time capture done for HTMLVideoElement on each of these interfaces.

Fixes w3c/webcodecs#158.
@chcunningham chcunningham mentioned this issue Aug 12, 2021
Merged
mfreed7 pushed a commit to mfreed7/html that referenced this issue Jun 3, 2022
@dalecurtis @mfreed7
Add WebCodecs VideoFrame as CanvasImageSource
8175b5e 
Adding VideoFrame as a CanvasImageSource allows drawImage(), createImageBitmap(), and texImage() to interoperate with VideoFrames. VideoFrames are effectively the same as the existing point-in-time capture done for HTMLVideoElement on each of these interfaces.

Fixes w3c/webcodecs#158.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
V1 Launch Blockers
Development

No branches or pull requests
2 participants
@dalecurtis @chcunningham