Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow header to enable features. #409

Closed
wants to merge 1 commit into from
Closed

Conversation

clelland
Copy link
Collaborator

@clelland clelland commented Oct 9, 2020

This allows the header alone to enable delegation of a feature to specific
origins, if not otherwise blocked or affected by the container policy. The
order of precedence becomes:

  1. Explicitly blocked by header: Disabled
  2. Explicitly blocked by allow attribute: Disabled
  3. Explicitly allowed by allow attribute: Enabled
  4. Explicitly allowed by header: Enabled
    5a. (Default behaviour when default allowlist is '*'): Enabled
    5b. (Default behaviour when default allowlist is 'self'): Enabled if same-
    origin; Disabled if cross-origin.

Fixes: #408

This allows the header alone to enable delegation of a feature to specific
origins, if not otherwise blocked or affected by the container policy. The
order of precedence becomes:

1. Explicitly blocked by header: Disabled
2. Explicitly blocked by allow attribute: Disabled
3. Explicitly allowed by allow attribute: Enabled
4. Explicitly allowed by header: Enabled
5a. (Default behaviour when default allowlist is '*'): Enabled
5b. (Default behaviour when default allowlist is 'self'): Enabled if same-
    origin; Disabled if cross-origin.

Fixes: #408
Copy link
Contributor

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-owner LGTM

@clelland
Copy link
Collaborator Author

Closing this; the resolution of #408 is that we're not going to make this change to the algorithms right now.

@clelland clelland closed this Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Header should be sufficient in some cases to delegate features (esp. Client Hints)
2 participants