Update animations.md #212
Merged
Update animations.md #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revised the animations policy to propose a modified policy that blocks layout inducing animations as opposed to the non-composited animations. The changed is motivated discussions in issues #202, #203, and #204.
Suggested a handful of animations to include in the v1 of the policy.
clelland
reviewed
Sep 20, 2018
policies/animations.md
Outdated
| Deeper explanation | ||
| In order to produce animations on the web, developers declare transitions of style | ||
| in either CSS (e.g., `@keyframes` and `animation`) or JavaScript (e.g., `element.animate()`). | ||
| In principal, these transitions can be used to animate just about any CSS property ( |
There was a problem hiding this comment.
Minor nit -- can you move the "(" to the next line to avoid unnecessary whitespace after it?
policies/animations.md
Outdated
| When properties such as `size` or `position` are changed in an animation, many other | ||
| elements on the page to have to be moved around constantly (*layout and re-layout*), and | ||
| browsers can struggle to keep up. When that happens, the result is a potentially stuttering | ||
| animation and a poorly performing and non-responsive web page; sometimes even the entire page |
There was a problem hiding this comment.
the entire page slows down
I realize that I missed a word in the original text -- I think I intended to say that in the worst case, the entire machine can slow down, as all CPU resources are devoted to the animation.
There was a problem hiding this comment.
page changed to machine
Addressing comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revised the animations policy to propose a modified policy that blocks layout inducing animations as opposed to the non-composited animations.
The changed is motivated discussions in issues #202, #203, and #204.