Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note that a UA may create a new credential from the selection UI #44

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Note that a UA may create a new credential from the selection UI #44

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
70ab1c1
Issue 18: Note that a UA may create a new credential from the selecti…
Dec 23, 2016
8ae019f
Moved statement about entering new credentials to #user-mediated-sele…
Jan 2, 2017
ea6485e
Merge
Feb 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2739,7 +2739,8 @@ <h4 class="heading settled" data-level="4.2.3" id="request-siteboundcredential-w
<li>
Ask the user which <code class="idl"><a data-link-type="idl" href="#credential" id="ref-for-credential-28">Credential</a></code> to share.
<p class="note" role="note">Note: This behavior is vendor-specific. Guidelines for user agent
behavior are presented in <a href="#user-mediation">§5 User Mediation</a>.</p>
behavior are presented in <a href="#user-mediation">§5 User Mediation</a>. A user agent MAY offer
the user to enter and save new credentials in this step.</p>
<li> Let <var>credential</var> be the <code class="idl"><a data-link-type="idl" href="#credential" id="ref-for-credential-29">Credential</a></code> the user chose, or <code>null</code> if the user chose not to share a credential with <var>origin</var>.
<li> Return <var>credential</var>.
</ol>
Expand Down
3 changes: 2 additions & 1 deletion index.src.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1738,7 +1738,8 @@ <h4 id="request-siteboundcredential-with-mediation">
Ask the user which {{Credential}} to share.

Note: This behavior is vendor-specific. Guidelines for user agent
behavior are presented in [[#user-mediation]].
behavior are presented in [[#user-mediation]]. A user agent MAY offer
the user to enter and save new credentials in this step.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like this addition would be better as a statement in https://w3c.github.io/webappsec-credential-management/#user-mediated-selection itself. We're already outlining the requirements for the UI there, so noting this there as well seems clearer.

</li>
<li>
Let <var>credential</var> be the {{Credential}} the user chose, or
Expand Down