Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "conditional mediation" #155

Merged
merged 14 commits into from
Dec 6, 2021
Merged

Add "conditional mediation" #155

Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
d40af4b
Add "conditional mediation"
equalsJeffH Feb 18, 2021
8009c48
merge from main and fix conflict
equalsJeffH Oct 18, 2021
0ad1ff8
Merge branch 'main' into jeffh-add-conditional-mediation-approach
equalsJeffH Oct 24, 2021
67f5689
it is {{conditional}} not [=conditional=]
equalsJeffH Oct 24, 2021
2209e8f
oops, it is really {{CredentialMediationRequirement/conditional}}
equalsJeffH Oct 24, 2021
3537786
Make several improvements
nsatragno Oct 25, 2021
9dc6bc8
Remove index.html
nsatragno Oct 25, 2021
9d9300b
Do not eat up errors.
nsatragno Oct 25, 2021
590437a
Merge branch 'main' into jeffh-add-conditional-mediation-approach
equalsJeffH Nov 1, 2021
c8c709e
Apply suggestions from code review
nsatragno Nov 1, 2021
b8624db
Address comments.
nsatragno Nov 4, 2021
146e74c
Apply suggestions from code review
nsatragno Nov 9, 2021
5d07770
Address comment.
nsatragno Nov 9, 2021
f970f51
merge from main and fix conflicts
equalsJeffH Nov 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
116 changes: 88 additions & 28 deletions index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,7 @@ spec:css-syntax-3;
interface Credential {
readonly attribute USVString id;
readonly attribute DOMString type;
static boolean isConditionalMediationAvailable();
nsatragno marked this conversation as resolved.
Show resolved Hide resolved
};
</pre>
<div dfn-for="Credential">
Expand All @@ -297,6 +298,24 @@ spec:css-syntax-3;
:: This attribute's getter returns the value of the object's [=interface object=]'s
{{[[type]]}} slot, which specifies the [=credential type=] represented by this object.

: <dfn method>isConditionalMediationAvailable()</dfn>
:: Returns `true` if and only if the user agent supports the
{{CredentialMediationRequirement/conditional}} approach to
[[#mediation-requirements|mediation of credential requests]] for the [=credential type=],
`false` otherwise.

{{Credential}}'s default implementation of {{Credential/isConditionalMediationAvailable()}}:

<ol class="algorithm">
1. Return `false`.
</ol>

The specification for any [=credential type=] supporting
{{CredentialMediationRequirement/conditional}} mediation must explicitly override this
function to return `true`.
Note: If this function is not present, {{CredentialMediationRequirement/conditional}}
mediation is not supported for the [=credential type=].
nsatragno marked this conversation as resolved.
Show resolved Hide resolved

: <dfn attribute>\[[type]]</dfn>
:: The {{Credential}} [=interface object=] has an internal slot named `[[type]]`, which
unsurprisingly contains a string representing the <dfn>credential type</dfn>. The slot's value
Expand Down Expand Up @@ -609,6 +628,7 @@ spec:css-syntax-3;
enum CredentialMediationRequirement {
"silent",
"optional",
"conditional",
"required"
};
</pre>
Expand All @@ -633,6 +653,26 @@ spec:css-syntax-3;
a user has just clicked "sign-in" for example, then they won't be surprised or confused to
see a [=credential chooser=] if necessary.

: <dfn>conditional</dfn>
:: Discovered credentials are presented to the user in a non-modal dialog along with an
indication of the [=origin=] which is requesting credentials. If the user makes a gesture
outside of the dialog, the dialog closes without resolving or rejecting the {{Promise}}
returned by the {{CredentialsContainer/get()}} method and without causing a user-visible
error condition. If the user makes a gesture that selects a credential, that credential is
returned to the caller. The [=prevent silent access flag=] is treated as being `true`
regardless of its actual value: the {{CredentialMediationRequirement/conditional}} behavior
always involves [=user mediation=] of some sort if applicable credentials are discovered.

If no credentials are discovered, the user agent MAY prompt the user to take action in a way
that depends on the type of credential (e.g. to insert a device containing credentials).
Either way, the `get()` method MUST NOT resolve immediately with `null` to avoid revealing
the lack of applicable credentials to the website.

Websites can only pass {{CredentialMediationRequirement/conditional}} into the
{{CredentialsContainer/get()}} method if all of the [=relevant credential interface objects|credential
interfaces it refers to=] have overridden {{Credential/isConditionalMediationAvailable()}} to return
`true`.

: <dfn>required</dfn>
:: The user agent will not hand over credentials without [=user mediation=], even if the
[=prevent silent access flag=] is unset for an origin.
Expand Down Expand Up @@ -769,64 +809,81 @@ spec:css-syntax-3;
<ol class="algorithm">
1. Let |settings| be the <a>current settings object</a>

2. Assert: |settings| is a [=secure context=].
1. Assert: |settings| is a [=secure context=].

3. If <code>|options|.{{CredentialRequestOptions/signal}}</code> is [=AbortSignal/aborted=],
1. If <code>|options|.{{CredentialRequestOptions/signal}}</code> is [=AbortSignal/aborted=],
then return [=a promise rejected with=]
<code>|options|.{{CredentialRequestOptions/signal}}</code>'s [=AbortSignal/abort reason=].

4. Let |p| be [=a new promise=].
1. If <code>|options|.{{CredentialRequestOptions/mediation}}</code> is
"{{CredentialMediationRequirement/conditional}}":

5. Let |origin| be the [=current settings object=]'s [=environment settings object/origin=].
1. For each |interface| in |options|' [=relevant credential interface objects=]:

6. Let |sameOriginWithAncestors| be `true` if |settings| is [=same-origin with its
1. If |interface| does not support {{CredentialMediationRequirement/conditional}}
[=user mediation=], return [=a promise rejected with=] a "{{TypeError}}" {{DOMException}}.

1. Let |p| be [=a new promise=].

1. Let |origin| be the [=current settings object=]'s [=environment settings object/origin=].

1. Let |sameOriginWithAncestors| be `true` if |settings| is [=same-origin with its
ancestors=], and `false` otherwise.

7. Run the following steps [=in parallel=]:
1. Run the following steps [=in parallel=]:

1. Let |credentials| be the result of <a abstract-op lt="collect local">collecting
`Credential`s from the credential store</a>, given |origin|, |options|, and
|sameOriginWithAncestors|.

2. If |credentials| is an [=exception=], [=reject=] |p| with |credentials|.
1. If |credentials| is an [=exception=], [=reject=] |p| with |credentials|.

3. If all of the following statements are true, resolve |p| with |credentials|[0] and
1. If all of the following statements are true, resolve |p| with |credentials|[0] and
skip the remaining steps:

1. |credentials|' [=set/size=] is 1

2. |origin| does not [=origin/requires user mediation|require user mediation=]
1. |origin| does not [=origin/requires user mediation|require user mediation=]

3. |options| is <a>matchable <i lang="la">a priori</i></a>.
1. |options| is <a>matchable <i lang="la">a priori</i></a>.

4. |options|.{{CredentialRequestOptions/mediation}} is not
1. |options|.{{CredentialRequestOptions/mediation}} is not
"{{CredentialMediationRequirement/required}}".

1. |options|.{{CredentialRequestOptions/mediation}} is not
"{{CredentialMediationRequirement/conditional}}".

ISSUE: This might be the wrong model. It would be nice to support a site that wished
to accept either username/passwords or webauthn-style credentials without forcing
a chooser for those users who use the former, and who wish to remain signed in.

4. If |options|' {{CredentialRequestOptions/mediation}} is
1. If |options|' {{CredentialRequestOptions/mediation}} is
"{{CredentialMediationRequirement/silent}}", [=resolve=] |p| with `null`, and skip
the remaining steps.

5. Let |choice| be the result of <a abstract-op lt="ask to choose">asking the user to
1. Let |result| be the result of <a abstract-op lt="ask to choose">asking the user to
choose a `Credential`</a>, given |options| and |credentials|.

6. If |choice| is `null` or a {{Credential}}, [=resolve=] |p| with |choice| and skip the
remaining steps.
1. If |result| is an [=interface object=]:

7. Assert: |choice| is an [=interface object=].
1. Set |result| to the result of executing |result|'s
{{[[DiscoverFromExternalSource]](origin, options, sameOriginWithAncestors)}},
given |origin|, |options|, and |sameOriginWithAncestors|.

8. Let |result| be the result of executing |choice|'s
{{[[DiscoverFromExternalSource]](origin, options, sameOriginWithAncestors)}},
given |origin|, |options|, and |sameOriginWithAncestors|.
1. Assert: |result| is `null`, a {{Credential}}, or an [=exception=].

9. If |result| is a {{Credential}} or `null`, resolve |p| with |result|.
1. If |result| is a {{Credential}}, [=resolve=] |p| with |result|.

Otherwise, [=reject=] |p| with |result|.
1. If |result| is an [=exception=], [=reject=] |p| with |result|.

7. Return |p|.
1. If |result| is `null` and |options|.{{CredentialRequestOptions/mediation}} is not
{{CredentialMediationRequirement/conditional}}, [=resolve=] |p| with |result|.

Note: if |options|.{{CredentialRequestOptions/mediation}} is
{{CredentialMediationRequirement/conditional}} and a `null` credential is discovered,
promise |p| is not resolved.
jyasskin marked this conversation as resolved.
Show resolved Hide resolved

1. Return |p|.
</ol>

<h4 id="algorithm-collect-known" algorithm>Collect `Credential`s from the credential store</h4>
Expand Down Expand Up @@ -919,7 +976,7 @@ spec:css-syntax-3;
types in order to support a "sign-up" use case. For the moment, though, we're punting
on that by restricting the dictionary to a single entry.

3. If <code>|options|.{{CredentialRequestOptions/signal}}</code> is [=AbortSignal/aborted=],
7. If <code>|options|.{{CredentialRequestOptions/signal}}</code> is [=AbortSignal/aborted=],
then return [=a promise rejected with=]
<code>|options|.{{CredentialRequestOptions/signal}}</code>'s [=AbortSignal/abort reason=].

Expand Down Expand Up @@ -2074,7 +2131,7 @@ spec:css-syntax-3;
</pre>
</div>

2. Define appropriate {{Credential/[[Create]](origin, options, sameOriginWithAncestors)}},
1. Define appropriate {{Credential/[[Create]](origin, options, sameOriginWithAncestors)}},
{{Credential/[[CollectFromCredentialStore]](origin, options, sameOriginWithAncestors)}},
{{Credential/[[DiscoverFromExternalSource]](origin, options, sameOriginWithAncestors)}}, and
{{Credential/[[Store]](credential, sameOriginWithAncestors)}} methods on `ExampleCredential`'s
Expand Down Expand Up @@ -2108,21 +2165,21 @@ spec:css-syntax-3;
1. ...
</div>

3. Define the value of the `ExampleCredential` [=interface object=]'s {{[[type]]}} slot:
1. Define the value of the `ExampleCredential` [=interface object=]'s {{[[type]]}} slot:

<div class="example">
The `ExampleCredential` [=interface object=] has an internal slot named `[[type]]` whose
value is the string "`example`".
</div>

4. Define the value of the `ExampleCredential` [=interface object=]'s {{[[discovery]]}} slot:
1. Define the value of the `ExampleCredential` [=interface object=]'s {{[[discovery]]}} slot:

<div class="example">
The `ExampleCredential` [=interface object=] has an internal slot named `[[type]]` whose
value is "{{Credential/[[discovery]]/credential store}}".
</div>

4. Extend {{CredentialRequestOptions}} with the options the new credential type needs to respond
1. Extend {{CredentialRequestOptions}} with the options the new credential type needs to respond
reasonably to {{get()}}:

<div class="example">
Expand All @@ -2137,7 +2194,7 @@ spec:css-syntax-3;
</pre>
</div>

5. Extend {{CredentialCreationOptions}} with the data the new credential type needs to create
1. Extend {{CredentialCreationOptions}} with the data the new credential type needs to create
`Credential` objects in response to {{create()}}:

<div class="example">
Expand All @@ -2152,6 +2209,9 @@ spec:css-syntax-3;
</pre>
</div>

1. If the new credential type supports {{CredentialMediationRequirement/conditional}} [=user
mediation=], define `ExampleCredential/isConditionalMediationAvailable()` to return `true`.

You might also find that new primitives are necessary. For instance, you might want to return
many {{Credential}} objects rather than just one in some sort of complicated, multi-factor
sign-in process. That might be accomplished in a generic fashion by adding a `getAll()` method to
Expand Down