fix issue #128 copy buffer sources #130
Conversation
| [=get a copy of the bytes held by the buffer source=] and | ||
| set |values|'s value to be a reference to the copy of the bytes. | ||
|
|
||
| issue: do we need to explicitly free the bytes we just orphaned? |
There was a problem hiding this comment.
The bytes that belong to |V| [|member|] aren't orphaned, as they are still rooted to |dictionary|. The return could get orphaned, but that's not this algorithm's fault.
There was a problem hiding this comment.
I was only referring to the buffer source bytes that we copied from and then overwrote the dictionary's references to them -- do we just assume there is garbage collection?
|
|
||
| 2. If |value|'s type is a [=buffer source type=] then | ||
| [=get a copy of the bytes held by the buffer source=] and | ||
| set |values|'s value to be a reference to the copy of the bytes. |
There was a problem hiding this comment.
Guessing you meant:
| set |values|'s value to be a reference to the copy of the bytes. | |
| set |value|'s value to be a reference to the copy of the bytes. |
There was a problem hiding this comment.
LOL!! yes, thanks :)
| [=dictionary=] type, run the following steps given |V|: | ||
|
|
||
| <ol class="algorithm"> | ||
| 1. Let |dictionaries| be a list consisting of |V| and all of |V|'s |
There was a problem hiding this comment.
Very Important Style Nit: The rest of the doc uses spaces, not tabs. :)
| @@ -548,6 +548,34 @@ <h1>Credential Management Level 1</h1> | |||
| to guide the discovery process (by choosing a federated identity provider, BTLE device, etc). | |||
| </div> | |||
|
|
|||
| <div algorithm="copy any buffer sources"> | |||
| To <dfn>create a copy of any buffer sources' data</dfn> referenced by a value |V| of | |||
There was a problem hiding this comment.
The following reads a little more clearly to me:
| To <dfn>create a copy of any buffer sources' data</dfn> referenced by a value |V| of | |
| To <dfn>create a copy of any buffer sources' data</dfn> referenced by a [=dictionary=] value |V|, run ... |
|
|
||
| <ol class="algorithm"> | ||
| 1. Let |dictionaries| be a list consisting of |V| and all of |V|'s | ||
| [=inherited dictionaries=], in order from least to most derived. |
There was a problem hiding this comment.
Why do you need to walk through the inherited dictionaries? Doesn't |V| itself already have all of the members of dictionaries from which it derives?
| 2. For each dictionary |dictionary| in |dictionaries|, in order: | ||
|
|
||
| 1. For each dictionary member |member| declared on | ||
| |dictionary|, in lexicographical order: |
There was a problem hiding this comment.
Rather than walking through the dictionaries, did you consider just walking through |V|'s members?
|
Ping! Let's keep this moving. :) |
fixes #128
this PR employs the proposed
<dfn>create a copy of any buffer sources' data</dfn>alg from #128 (comment)see also: https://lists.w3.org/Archives/Public/public-webappsec/2018Oct/0027.html and https://lists.w3.org/Archives/Public/public-webappsec/2018Oct/0032.html
Preview | Diff