Ensure that more complicated filters are possible to add in the future. #27
Comments
|
Ok, "revert" was a bit much. Wrapping the values in quotes is enough for the moment, as it will allow us to expand the filters with a more complete JSON syntax in the future once we have some implementation experience to learn from. |
yzyz
pushed a commit
to yzyz/chromium
that referenced
this issue
Jun 12, 2017
We've shifted from an explicit JSON dictionary to a list of quoted
strings (that can be parsed as JSON for forward-compatibility). That is,
rather than `Clear-Site-Data: { "types": [ "cookies", "cache" ] }`,
we'll use `Clear-Site-Data: "cookies", "cache"` to mean the same thing.
Spec change in w3c/webappsec-clear-site-data#27.
BUG=607897
Review-Url: https://codereview.chromium.org/2929593002
Cr-Commit-Position: refs/heads/master@{#478585}
yzyz
pushed a commit
to yzyz/chromium
that referenced
this issue
Jun 12, 2017
…omium#2 id:20001 of https://codereview.chromium.org/2929593002/ ) Reason for revert: Despite passing all the bots, this apparently breaks `content_browsertests`: https://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Tests&number=57936. So, let's go fix that. Original issue's description: > Align `clear-site-data` syntax with the spec. > > We've shifted from an explicit JSON dictionary to a list of quoted > strings (that can be parsed as JSON for forward-compatibility). That is, > rather than `Clear-Site-Data: { "types": [ "cookies", "cache" ] }`, > we'll use `Clear-Site-Data: "cookies", "cache"` to mean the same thing. > > Spec change in w3c/webappsec-clear-site-data#27. > > BUG=607897 > > Review-Url: https://codereview.chromium.org/2929593002 > Cr-Commit-Position: refs/heads/master@{#478585} > Committed: https://chromium.googlesource.com/chromium/src/+/085b57ffe70b6cb90cd77b61585babcf59df3a95 [email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=607897 Review-Url: https://codereview.chromium.org/2933083002 Cr-Commit-Position: refs/heads/master@{#478594}
yzyz
pushed a commit
to yzyz/chromium
that referenced
this issue
Jun 12, 2017
We've shifted from an explicit JSON dictionary to a list of quoted
strings (that can be parsed as JSON for forward-compatibility). That is,
rather than `Clear-Site-Data: { "types": [ "cookies", "cache" ] }`,
we'll use `Clear-Site-Data: "cookies", "cache"` to mean the same thing.
Spec change in w3c/webappsec-clear-site-data#27.
BUG: 607897
Change-Id: I051dcc49f9ed108e117347ccd7e249781433302b
Reviewed-on: https://chromium-review.googlesource.com/530748
Reviewed-by: Martin Šrámek <[email protected]>
Commit-Queue: Mike West <[email protected]>
Cr-Commit-Position: refs/heads/master@{#478633}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In https://www.w3.org/2011/webappsec/draft-minutes/2017-05-17-webappsec-minutes.html#item06, @devd suggested that we should provide better filtering capabilities for cookies. We don't know what those capabilities need to be, but we need a syntax that's flexible enough to allow them in the future, once we get more feedback from developers. So, let's revert and refine #17.
/cc @msramek
The text was updated successfully, but these errors were encountered: