Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand/clarify "single pointer" definition #809

Merged
merged 5 commits into from
Aug 16, 2022
Merged

Expand/clarify "single pointer" definition #809

merged 5 commits into from
Aug 16, 2022

Conversation

patrickhlauke
Copy link
Member

Closes #749

@patrickhlauke patrickhlauke mentioned this pull request Jun 28, 2019
Closed
@patrickhlauke patrickhlauke force-pushed the patrickhlauke-issue749 branch from 0f6d8b4 to eb22310 Compare June 28, 2019 19:49
@patrickhlauke
Copy link
Member Author

were there any particular problems/objections to this being updated in 2.2?

michael-n-cooper
michael-n-cooper suggested changes Apr 9, 2020
View reviewed changes
Copy link
Member

@michael-n-cooper michael-n-cooper left a comment •
edited by patrickhlauke
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues with content from me. But structurally, our style for definitions (for better or worse, it's what was decided for WCAG 2) is that the definition should in principle be able to be dropped into the spec in place of the term and still make sense. This applies to the first para of the definition, which should be a phrase, with no starting cap or ending punctuation. Subsequent paras can provide additional information. This is just a moving words around problem but I don't have a strong enough suggestion to propose.

Structurally, the note should be <p class="note"> instead of starting with the term "Note:", that will cause respec to format it consistently.

@patrickhlauke
Copy link
Member Author

so would switching the sentence around work, i.e. starting the definition with Pointer Events [!pointerevents]... and removing the full stop at the end, and then moving the <p>A single pointer operation...</p> after it?

@patrickhlauke patrickhlauke mentioned this pull request Jul 22, 2020
Closed
@patrickhlauke
Copy link
Member Author

@michael-n-cooper sorry, coming back to this a bit late, but I think I made the changes you mentioned to the actual format (first sentence being "drop-in-able", and use of class="note"). mind giving this another look over/review from the technical side?

@alastc any chance this small tweak here can still be considered for 2.1 errata?

@patrickhlauke
Reword the expanded single pointer definition, tweak pointer input de…
7c7a6e8 
…finition

based on @michael-n-cooper 's feedback, changed the first sentence to be "able to be dropped into the spec in place of the term and still make sense", hopefully.
added the distinction to / mention of multitouch in contrast to single pointer interaction

avoiding repetition, removed the reference to Pointer Events spec from my original PR from the single pointer definiton as that's already covered in the definition for "pointer input", but made sure to make the cross-reference to that from the "single pointer" definition actually a link (which I think gets automagically turned into the correct link to the definiton?)
@patrickhlauke patrickhlauke force-pushed the patrickhlauke-issue749 branch from f15d00c to 7c7a6e8 Compare July 22, 2020 22:19
@patrickhlauke
Copy link
Member Author

ping @alastc (while i'm going through my PR left hanging open for ages)

@patrickhlauke
Copy link
Member Author

Ping @alastc again

Base automatically changed from master to main March 5, 2021 20:42
@yatil yatil mentioned this pull request Apr 22, 2021
Closed
patrickhlauke and others added 2 commits April 22, 2021 13:06
@patrickhlauke
Further try to disambiguate "input" (event/action) from device (hardw…
c3ab3a1 
…are)
@alastc
Updates from meeting
50ad290 
https://www.w3.org/2021/07/06-ag-minutes.html#item04
There were objections to such a large change as an errata.
Kept the normative to editorial and used the other content in the pointer-gestures understanding.
@alastc
Copy link
Contributor

alastc commented Jul 13, 2021

Agreed in meeting, will need to CFC for the editorial errata.

@patrickhlauke
Copy link
Member Author

@alastc any more movement on this?

@patrickhlauke
Copy link
Member Author

Coming up to the three year anniversary of this pull request...are there any objections to it? if not...any chance it might at some point be merged? @alastc

@patrickhlauke
Copy link
Member Author

@alastc @fstrr or anybody else...?

@patrickhlauke patrickhlauke added 2.5.1 Pointer Gestures ErratumRaised Potential erratum for a Recommendation and removed WCAG.next WCAG 2.2 labels Aug 9, 2022
@alastc alastc merged commit c90d083 into main Aug 16, 2022
@patrickhlauke
Copy link
Member Author

party time :shipit:

@patrickhlauke patrickhlauke deleted the patrickhlauke-issue749 branch August 16, 2022 15:33
@alastc alastc added the Errata Erratum to a Recommendation label Aug 16, 2022
@patrickhlauke patrickhlauke mentioned this pull request Dec 8, 2023
Merged
alastc added a commit that referenced this pull request Mar 11, 2024
@patrickhlauke @alastc
Update definition for single pointer (#3536)
a9dbe11 
The definition for "single pointer" has had issues for a long time, as
it mixes the idea of what a pointer *is* with the action(s) *performed*
using a pointer.

I originally tried to fix this, but there was no appetite for it once
2.1 was released. However, with 2.2 and the new 2.5.7 Dragging Movement
SC, the broken definition is causing actual misunderstandings/illogical
non-sequiturs.

See #749 (comment) and
the recent #3535 where this is once
again causing a non-sequitur

Closes #3535

(this is effectively a follow-up to #809
which had disambiguated things, but the definition had since been
changed further/again to reintroduce the ambiguous wording we have at
this point which confuses input with action)

This would be applied to WCAG 2.1 and 2.2, unless there is a decision to
only apply it to 2.2.

EDIT: Also closes #394


<!--
    This comment and the below content is programmatically generated.
    You may add a comma-separated list of anchors you'd like a
    direct link to below (e.g. #idl-serializers, #idl-sequence):

    Don't remove this comment or modify anything below this line.
    If you don't want a preview generated for this pull request,
    just replace the whole of this comment's content by "no preview"
    and remove what's below.
-->
***
<a href="https://pr-preview.s3.amazonaws.com/w3c/wcag/pull/3536.html"
title="Last updated on Mar 8, 2024, 7:30 PM UTC (6c36df1)">Preview</a> |
<a
href="https://pr-preview.s3.amazonaws.com/w3c/wcag/3536/afbf9ee...6c36df1.html"
title="Last updated on Mar 8, 2024, 7:30 PM UTC (6c36df1)">Diff</a>

---------

Co-authored-by: Alastair Campbell <[email protected]>
kfranqueiro pushed a commit that referenced this pull request Dec 18, 2024
@patrickhlauke @kfranqueiro
Update definition for single pointer (#3536)
04038fc 
The definition for "single pointer" has had issues for a long time, as
it mixes the idea of what a pointer *is* with the action(s) *performed*
using a pointer.

I originally tried to fix this, but there was no appetite for it once
2.1 was released. However, with 2.2 and the new 2.5.7 Dragging Movement
SC, the broken definition is causing actual misunderstandings/illogical
non-sequiturs.

See #749 (comment) and
the recent #3535 where this is once
again causing a non-sequitur

Closes #3535

(this is effectively a follow-up to #809
which had disambiguated things, but the definition had since been
changed further/again to reintroduce the ambiguous wording we have at
this point which confuses input with action)

This would be applied to WCAG 2.1 and 2.2, unless there is a decision to
only apply it to 2.2.

EDIT: Also closes #394

<!--
    This comment and the below content is programmatically generated.
    You may add a comma-separated list of anchors you'd like a
    direct link to below (e.g. #idl-serializers, #idl-sequence):

    Don't remove this comment or modify anything below this line.
    If you don't want a preview generated for this pull request,
    just replace the whole of this comment's content by "no preview"
    and remove what's below.
-->
***
<a href="https://pr-preview.s3.amazonaws.com/w3c/wcag/pull/3536.html"
title="Last updated on Mar 8, 2024, 7:30 PM UTC (6c36df1)">Preview</a> |
<a
href="https://pr-preview.s3.amazonaws.com/w3c/wcag/3536/afbf9ee...6c36df1.html"
title="Last updated on Mar 8, 2024, 7:30 PM UTC (6c36df1)">Diff</a>

---------

Co-authored-by: Alastair Campbell <[email protected]>
(cherry picked from commit a9dbe11)
kfranqueiro pushed a commit that referenced this pull request Dec 18, 2024
@patrickhlauke @kfranqueiro
Update definition for single pointer (#3536)
dda3649 
The definition for "single pointer" has had issues for a long time, as
it mixes the idea of what a pointer *is* with the action(s) *performed*
using a pointer.

I originally tried to fix this, but there was no appetite for it once
2.1 was released. However, with 2.2 and the new 2.5.7 Dragging Movement
SC, the broken definition is causing actual misunderstandings/illogical
non-sequiturs.

See #749 (comment) and
the recent #3535 where this is once
again causing a non-sequitur

Closes #3535

(this is effectively a follow-up to #809
which had disambiguated things, but the definition had since been
changed further/again to reintroduce the ambiguous wording we have at
this point which confuses input with action)

This would be applied to WCAG 2.1 and 2.2, unless there is a decision to
only apply it to 2.2.

EDIT: Also closes #394

<!--
    This comment and the below content is programmatically generated.
    You may add a comma-separated list of anchors you'd like a
    direct link to below (e.g. #idl-serializers, #idl-sequence):

    Don't remove this comment or modify anything below this line.
    If you don't want a preview generated for this pull request,
    just replace the whole of this comment's content by "no preview"
    and remove what's below.
-->
***
<a href="https://pr-preview.s3.amazonaws.com/w3c/wcag/pull/3536.html"
title="Last updated on Mar 8, 2024, 7:30 PM UTC (6c36df1)">Preview</a> |
<a
href="https://pr-preview.s3.amazonaws.com/w3c/wcag/3536/afbf9ee...6c36df1.html"
title="Last updated on Mar 8, 2024, 7:30 PM UTC (6c36df1)">Diff</a>

---------

Co-authored-by: Alastair Campbell <[email protected]>
(cherry picked from commit a9dbe11)
kfranqueiro pushed a commit that referenced this pull request Dec 19, 2024
@patrickhlauke @kfranqueiro
Update definition for single pointer (#3536)
b61e772 
The definition for "single pointer" has had issues for a long time, as
it mixes the idea of what a pointer *is* with the action(s) *performed*
using a pointer.

I originally tried to fix this, but there was no appetite for it once
2.1 was released. However, with 2.2 and the new 2.5.7 Dragging Movement
SC, the broken definition is causing actual misunderstandings/illogical
non-sequiturs.

See #749 (comment) and
the recent #3535 where this is once
again causing a non-sequitur

Closes #3535

(this is effectively a follow-up to #809
which had disambiguated things, but the definition had since been
changed further/again to reintroduce the ambiguous wording we have at
this point which confuses input with action)

This would be applied to WCAG 2.1 and 2.2, unless there is a decision to
only apply it to 2.2.

EDIT: Also closes #394

<!--
    This comment and the below content is programmatically generated.
    You may add a comma-separated list of anchors you'd like a
    direct link to below (e.g. #idl-serializers, #idl-sequence):

    Don't remove this comment or modify anything below this line.
    If you don't want a preview generated for this pull request,
    just replace the whole of this comment's content by "no preview"
    and remove what's below.
-->
***
<a href="https://pr-preview.s3.amazonaws.com/w3c/wcag/pull/3536.html"
title="Last updated on Mar 8, 2024, 7:30 PM UTC (6c36df1)">Preview</a> |
<a
href="https://pr-preview.s3.amazonaws.com/w3c/wcag/3536/afbf9ee...6c36df1.html"
title="Last updated on Mar 8, 2024, 7:30 PM UTC (6c36df1)">Diff</a>

---------

Co-authored-by: Alastair Campbell <[email protected]>
(cherry picked from commit a9dbe11)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-n-cooper michael-n-cooper michael-n-cooper approved these changes

@alastc alastc Awaiting requested review from alastc

Assignees
No one assigned
Labels
2.5.1 Pointer Gestures Errata Erratum to a Recommendation ErratumRaised Potential erratum for a Recommendation Survey - Added WCAG 2.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"single pointer" definition not quite accurate?
4 participants
@patrickhlauke @alastc @michael-n-cooper @awkawk