Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update references in non-normative docs #3854

Merged
merged 8 commits into from
Jun 11, 2024
Merged

Update references in non-normative docs #3854

merged 8 commits into from
Jun 11, 2024

Conversation

fstrr
Copy link
Contributor

@fstrr fstrr commented May 10, 2024 •
edited by mbgower
Loading

  • Replace reference to focus section of HTML 4.01 spec with reference to focus section of the HTML living standard in non-normative documents
  • correct uses of lists to be either unordered or ordered as appropriate
  • correct relative links

@fstrr
Update focus-order - replace reference to HTML 4.01 spec
8666ca2 
Replace reference to focus section of HTML 4.01 spec with reference to focus section of the HTML living standard.
patrickhlauke and others added 5 commits May 28, 2024 10:10
@patrickhlauke @alastc
@mbgower @WilcoFiers @fstrr
Rewrite for 3.3.1 Error Identification understanding document (#1651)
095aa3e 
* remove the misleading statement about screen reader users needing to
know that an error occurred before hitting one of the indicators/fields.
this implicitly suggests that the intent is for an error message/list to
be shown to (screen reader) users before the actual form, which is not
in fact the intention nor the requirement of this SC
* tweak the benefit for users with cognitive/language/learning
disabilities
* refocus on the benefit to ALL users, not just screen reader users
* ~add allowance for situations where an error indication is already
self-explanatory/obvious from context (e.g. a form where fields have
already explicitly been identified as mandatory/required - not necessary
for compliance to now ALSO explicitly say "as we already told you, this
field is mandatory")~ [potentially removed by mbgower suggestion]

Closes #977

---------

Co-authored-by: Alastair Campbell <[email protected]>
Co-authored-by: Mike Gower <[email protected]>
Co-authored-by: Wilco Fiers <[email protected]>
Co-authored-by: Mike Gower <[email protected]>
@giacomo-petri @bruce-usab
@mbgower @fstrr
Restore Target Size (Enhanced) Understanding Doc content (#3638)
a72a9bf 
Closes: #3617

This PR restores content in the 2.5.5 Target Size (Enhanced)
understanding document that was lost during the transition from 2.1
(when it was just "Target Size") to 2.2 (after the 2.5.8 Minimum version
was added, and 2.5.5 become "Enhanced").
Specifically, it adds back:
- exceptions in the intent section
- additional examples

Some code indentations were also modified to improve code readability.
These do not affect the resulting HTML document.

The resulting Understanding document (without CSS styling) can be viewed
[here](https://raw.githack.com/w3c/wcag/giacomo-petri-target-size-enhanced-patch/understanding/21/target-size-enhanced.html)

---------

Co-authored-by: Bruce Bailey <[email protected]>
Co-authored-by: Mike Gower <[email protected]>
@patrickhlauke @mbgower @fstrr
Change <ol> to <ul> when no order is intended (non-normative) (#3518
b4a139b 
)

The understanding documents are oddly inconsistent when it comes to use
of `<ol>` and `<ul>`. This edits all cases (particularly in the newer
2.2 understanding docs, but some older ones too) where a list does not
have an explicit order and should just be an unordered list

<!--
    This comment and the below content is programmatically generated.
    You may add a comma-separated list of anchors you'd like a
    direct link to below (e.g. #idl-serializers, #idl-sequence):

    Don't remove this comment or modify anything below this line.
    If you don't want a preview generated for this pull request,
    just replace the whole of this comment's content by "no preview"
    and remove what's below.
-->
***
<a href="https://pr-preview.s3.amazonaws.com/w3c/wcag/pull/3518.html"
title="Last updated on Mar 23, 2024, 3:47 PM UTC (44277aa)">Preview</a>
| <a
href="https://pr-preview.s3.amazonaws.com/w3c/wcag/3518/bf44269...44277aa.html"
title="Last updated on Mar 23, 2024, 3:47 PM UTC (44277aa)">Diff</a>

---------

Co-authored-by: Mike Gower <[email protected]>
@patrickhlauke @alastc
@mbgower @fstrr
Add sufficient technique for 2.4.7 using :focus-visible (#3272)
72438f3 
Two years late, but: here's the technique I intended to write for
#301 (comment)

(but a recent lengthy discussion on mailing list reminded me that back
in #301 the WG had indeed agreed this interpretation)

[Preview of new
techinque](https://raw.githack.com/w3c/wcag/patrickhlauke-focus-visible-technique/techniques/css/C45.html)

---------

Co-authored-by: Alastair Campbell <[email protected]>
Co-authored-by: Mike Gower <[email protected]>
@fstrr
Update focus order understanding page
e1ab174 
1. Replace reference to HTML 4.01 spec to link to HTML living standard
2. Link to 1.3.2 instead of just referencing it
3. Add a couple of `code` tags
4. Tided up whitespace (sorry…)
@mbgower mbgower changed the title Update focus-order - replace reference to HTML 4.01 spec Update references in non-normative docs May 28, 2024
@mgifford
Copy link

@fstrr it seems like this is a patch that covers more than what is in the initial post. Could we get this updated to cover some of the new content that seems to be added? The description makes it sounds like a straight forward shift in existing content, but I do think there is more in it than this.

@mbgower
Copy link
Contributor

mbgower commented Jun 4, 2024

@fstrr it seems like this is a patch that covers more than what is in the initial post. Could we get this updated to cover some of the new content that seems to be added? The description makes it sounds like a straight forward shift in existing content, but I do think there is more in it than this.

@mgifford can you cite an example of what you're talking about?
@fstrr if you are aware and agree, can you please include those differences in the summary of the PR?

@mbgower
Apply suggestions from code review
b58ebd5 
Fixing accidental conflict that was resolved in the wrong direction!
@mbgower mbgower merged commit e041c1c into main Jun 11, 2024
1 check passed
@mbgower
Copy link
Contributor

mbgower commented Jun 11, 2024

@mgifford since this has good support from the AGWG review, and you have not provided any examples, I am merging. If you continue to think this PR has introduced an issue, please open a new issue to resolve.

@mbgower mbgower deleted the fstrr-patch-7 branch June 11, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbgower mbgower mbgower left review comments

Assignees
No one assigned
Labels
Editorial Understanding
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fstrr @mgifford @mbgower @patrickhlauke @giacomo-petri