Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update reflow.html to have responsive video #3430

Closed
wants to merge 3 commits into from

Conversation

davatron5000
Copy link

@davatron5000 davatron5000 commented Sep 26, 2023

👋 In a somewhat unexpected twist, the page for understanding the WCAG rule about not having two-dimensional scrollbars had two-dimensional scrollbars due to an overflowing video. This fix addresses that.

  • Add height/width to <video> to establish aspect-ratio
  • Add style="max-width: 100%; height: auto" to allow video to squish and maintain aspect ratio.

The inline style attribute is regrettable but there were no instructions on how to build the project locally so I couldn't pinpoint how style.css was being generated or included.

Closes #3401

@w3cbot
Copy link

w3cbot commented Sep 26, 2023

dontcallmedom marked as non substantive for IPR from ash-nazg.

@patrickhlauke
Copy link
Member

see also #3401

I suggest this should actually be fixed at source/in the main stylesheet, not on an ad-hoc basis

Copy link
Member

@patrickhlauke patrickhlauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest this change is made in the general stylesheet used for understanding docs instead

@davatron5000
Copy link
Author

Ok. Just so I'm clear, I should fork the the wai-website-theme repo and PR a fix for video styles there? Is that what you mean by "general stylesheet"?

https://github.com/w3c/wai-website-theme/blob/master/_components/images.css#L20

I can update this PR to only add the height/width which will help with the overall CLS.

@davatron5000
Copy link
Author

Upstream PR created w3c/wai-website-theme#58

@patrickhlauke
Copy link
Member

thanks @davatron5000 ... I'll leave @alastc @iadawn to comment here on whether or not this upstream PR is all that's needed (as I'm not sure if it's different teams/people responsible for these things)

@patrickhlauke
Copy link
Member

As this dropped off the radar, added to the WCAG 2.x backlog

@alastc
Copy link
Contributor

alastc commented Mar 29, 2024

There's no change included in the PR, do we need to update the CSS for the repo?

@fstrr
Copy link
Contributor

fstrr commented Mar 29, 2024

@alastc There's an upstream PR for this on the WAI website theme repo., which was approved last year. I've emailed @iadawn to see if we can get this live.

@patrickhlauke
Copy link
Member

Closing this as it was fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Video causes horizontal scroll on page
5 participants