-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update reflow.html to have responsive video #3430
Conversation
dontcallmedom marked as non substantive for IPR from ash-nazg. |
see also #3401 I suggest this should actually be fixed at source/in the main stylesheet, not on an ad-hoc basis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest this change is made in the general stylesheet used for understanding docs instead
Ok. Just so I'm clear, I should fork the the https://github.com/w3c/wai-website-theme/blob/master/_components/images.css#L20 I can update this PR to only add the height/width which will help with the overall CLS. |
Upstream PR created w3c/wai-website-theme#58 |
thanks @davatron5000 ... I'll leave @alastc @iadawn to comment here on whether or not this upstream PR is all that's needed (as I'm not sure if it's different teams/people responsible for these things) |
As this dropped off the radar, added to the WCAG 2.x backlog |
There's no change included in the PR, do we need to update the CSS for the repo? |
@alastc There's an upstream PR for this on the WAI website theme repo., which was approved last year. I've emailed @iadawn to see if we can get this live. |
Closing this as it was fixed |
👋 In a somewhat unexpected twist, the page for understanding the WCAG rule about not having two-dimensional scrollbars had two-dimensional scrollbars due to an overflowing video. This fix addresses that.
height
/width
to<video>
to establishaspect-ratio
Addstyle="max-width: 100%; height: auto"
to allow video to squish and maintain aspect ratio.The inline
style
attribute is regrettable but there were no instructions on how to build the project locally so I couldn't pinpoint howstyle.css
was being generated or included.Closes #3401