Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syntax highlighting for html techniques #3381

Closed
wants to merge 69 commits into from
Closed

Syntax highlighting for html techniques #3381

wants to merge 69 commits into from

Conversation

fstrr
Copy link
Contributor

@fstrr fstrr commented Sep 8, 2023

  • update code to support syntax highlighting libraries

Also:

  • fix typos
  • fix / replace broken links
  • remove references to XHTML and HTML5

fstrr added 30 commits September 1, 2023 14:04
@fstrr
Update H2
26f403a 
* add syntax highlighting support
* fix broken link
@fstrr
Update h24 for syntax highlighting
5254832
@fstrr
Update h25 for syntax highlighting support
7fee788
@fstrr
Update h28
3bea235 
* add support for syntax highlighting
* update one example
@fstrr
Update h30 for syntax highlighting support
be168c2
@fstrr
Update h32 for syntax highlighting support
0cc7e43
@fstrr
Update H33
8b1b956 
* added support for syntax highlighting
* updated resources link
@fstrr
Update H34 - update out of date resource links
2fc240a
@fstrr
Update h36 for syntax highlighting
6f354cc
@fstrr
Update h37 for syntax highlighting
1aebc64
@fstrr
Update H39 for syntax highlighting
3c191e6
@fstrr
Update H40 for syntax highlighting
8a1c27b
@fstrr
Update h42 for syntax highlighting
0e7d7d8
@fstrr
Update h43 for syntax highlighting
a7fe836
@fstrr
Update h44 for syntax highlighting
1e45360
@fstrr
H48 update el class
3d7f985
@fstrr
Update el class attributes
b3992d0
@fstrr
Update H49 for syntax highlighting
ae307e4
@fstrr
Update H51 for syntax highlighting
5e03dd1
@fstrr
Update H53
2ec5538 
* syntax highlighting
* replaced HTML 4.01 link to living standard
@fstrr
Update H54
f717de5 
* support for syntax highlighting
* replaced HTML 4.01 link to living standard
@fstrr
Update H56
7073de2 
* syntax highlighting
* replaced out of date resource link
@fstrr
Update H57 for syntax highlighting
eba5219
@fstrr
Update H58 for syntax highlighting
12352df
@fstrr
Update H59 for syntax highlighting
4ae5cc4 
Note: this technique should be retired. See: [issue 1234](#1234)
@fstrr
H58: add lang to German code sample
0f062c2
@fstrr
Update H62
4211805 
* add support for syntax highlighting
* update links from W3C HTML spec to WHATWG
* add lang support for change of languages
* removed references to XHTML and HTML5
@fstrr
Update H63
80e2514 
* add support for syntax highlighting
* remove references to XHTML
* update Resources links
* remove test to check that `td` elements have `scope` attribute as that’s invalid HTML now
* swapped a male name for a female one
@fstrr
Update H64 for syntax highlighting
eccb389
@fstrr
Update H65
4218577 
* add support for syntax highlighting
* remove references to HTML 4.01
@patrickhlauke
Update techniques/html/H100.html
b9baf15
@patrickhlauke
Fixes
bd25fe8
@patrickhlauke
preserve whitespace for <pre>
b6e1cbd
@patrickhlauke
Replace closing <link …></link> with self-closing <link … />
619150a 
Should be safe, as H100.html already does this and renders fine. Should probably be run over entire repo
@patrickhlauke
Copy link
Member

@mbgower @alastc reviewed, made a few fixes, snuck in a few long-overdue changes (just in the html techniques folder, but likely should do same on all other html files ... will do in a separate PR), and validated all files. this should be good to go.

@bruce-usab
Copy link
Contributor

@fstrr or @mbgower : my apologies I accidently changed the project status , please revert as appropriate.

@bruce-usab
Copy link
Contributor

Discussed on call 1/12. We noted need for Preview and that build errors need to be resolved.

@alastc
Copy link
Contributor

alastc commented Jan 15, 2024

I started, there's a few tricky conflicts and it won't build yet, so it's taking a while.

@alastc
Copy link
Contributor

alastc commented Feb 26, 2024

Merge conflicts resolved, build working, and preview looks good.

@mbgower Let's move this one across the board quickly before we get more merge conflicts!

@mbgower
Copy link
Contributor

mbgower commented Mar 8, 2024

@alastc not easily finding a link to the preview; can you please post?

@mbgower
Copy link
Contributor

mbgower commented Mar 25, 2024

@fstrr either you or @patrickhlauke was going to clean these conflicts up as part of whichever of your holistic PRs was regarded as the 'top gun'. Have you had a chance to discuss?

@fstrr
Copy link
Contributor Author

fstrr commented Mar 25, 2024

@mbgower I'm working on it. Got a bunch of merge conflicts to deal with, but am hoping to get this finished and pushed up today.

fstrr added a commit that referenced this pull request Mar 25, 2024
@fstrr
Merge two PRs: #3381 and #3738
3cfa340 
Merges #3381 and #3738 to:

- update / correct WCAG links
- update resource links
- add support for syntax highlighting
@fstrr fstrr mentioned this pull request Mar 25, 2024
Merged
@fstrr
Copy link
Contributor Author

fstrr commented Mar 25, 2024

@mbgower @patrickhlauke I merged our two branches and I think everything's good. Definitely needs a good look to be sure.

@bruce-usab bruce-usab mentioned this pull request Mar 25, 2024
Closed
@alastc alastc closed this Mar 29, 2024
@patrickhlauke
Copy link
Member

superseded by #3757

mbgower pushed a commit that referenced this pull request Apr 16, 2024
@fstrr @patrickhlauke
@alastc @bruce-usab
Merge pr3381 and pr3738 (#3757)
dd4939b 
Merges #3381 and #3738 to:

- update / correct WCAG links
- update resource links
- add support for syntax highlighting
- remove references to XHTML

Closes #3381 
Closes #3738

---------

Co-authored-by: Patrick H. Lauke <[email protected]>
Co-authored-by: Alastair Campbell <[email protected]>
Co-authored-by: Bruce Bailey <[email protected]>
@patrickhlauke patrickhlauke deleted the syntax-highlighting-for-html-techniques branch September 8, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhlauke patrickhlauke patrickhlauke left review comments

@Dubersnack Dubersnack Dubersnack approved these changes

@bruce-usab bruce-usab bruce-usab approved these changes

@alastc alastc alastc approved these changes

@hidde hidde hidde approved these changes

Assignees

@alastc alastc

@patrickhlauke patrickhlauke

@mbgower mbgower

@fstrr fstrr

Labels
Bug Fixes Editorial Techniques
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@fstrr @patrickhlauke @bruce-usab @alastc @mbgower @hidde @Dubersnack