Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken link to on-focus document #3073

Closed
wants to merge 1 commit into from
Closed

fix broken link to on-focus document #3073

wants to merge 1 commit into from

Conversation

fstrr
Copy link
Contributor

@fstrr fstrr commented Feb 28, 2023

No description provided.

@mbgower
Copy link
Contributor

mbgower commented Nov 24, 2023

Not working across all versions of WCAG. 2.2 works but not 2.1 -- and likely not main. Some magic happening somewhere...

@patrickhlauke
Copy link
Member

for further context: the # relative link is needed when the SC is in the spec, but this PR seems to try and fix it for when the SC is pulled into understanding. understanding for 2.2 works (seems to have some hardcoded fix to add in the absolute url reference back to spec), but doesn't seem to work currently in 2.1

but fundamentally we don't want to change this in the SC itself, as it still needs to be the # relative in-page link for when it's in the spec.

@kfranqueiro
Copy link
Contributor

Seeing this PR for the first time, and confirming this should not be changed - it currently works as intended both within guidelines/index.html and within built understanding pages.

RE 2.1, this will be resolved once we get that rebuilt (which #4007 is a big step towards).

@kfranqueiro kfranqueiro deleted the fstrr-patch-9 branch October 18, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants