1.4.11 Non-text Contrast understanding: expand explanation for Figure 10 #2681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides some actual context about *why* the green border doesn't need to contrast with the button itself, and moves the easily missed extra prose that follows into the actual figure caption (as it's currently easy to miss when skimming over the document)
|
This could be backported to 2.1 as well (removing the link to the focus appearance SC) |
bruce-usab
approved these changes
Dec 8, 2023
|
Might be an idea to generate a preview copy so folks can easily review in context -- even a screen shot of the pertinent paragraphs in your local build would be useful to some for context. |
bruce-usab
reviewed
Feb 2, 2024
bruce-usab
approved these changes
Feb 2, 2024
mbgower
reviewed
Feb 9, 2024
patrickhlauke
commented
Feb 23, 2024
scottaohara
approved these changes
Feb 23, 2024
mbgower
deleted the
patrickhlauke-non-text-contrast-understanding-tweak
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides some actual context about why the green border doesn't need to contrast with the button itself, and moves the easily missed extra prose that follows into the actual figure caption (as it's currently easy to miss when skimming over the document)