Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For publication / deploy on Tuesday May 28, 2024 #327

Merged
merged 8 commits into from
May 28, 2024
Merged

Conversation

howard-e
Copy link
Contributor

@howard-e howard-e commented May 23, 2024

We would like to deploy a new version of the APG. This was approved during the May 21, 2024 APG meeting and during a recent email thread with @mcking65.

The update includes the following, as sourced from the 2024-05-23 APG Publication Pull Requests milestones and recent w3c#aria-practices commits to main:

About: Add page to about section that explains the AT support tables (pull #3000)

By Matt King on May 22, 2024

  • Adds a page to the about section that explains AT support tables.
  • Adds link to the new about AT support table page from each of the example pages that includes an AT support table.

Co-authored-by: Boaz Sender

View commit 2e21c92


Feed Example: Move display of example from separate page into standard APG example page (pull #2775)

By Ariella Gilmore on May 22, 2024

Enables the feed example to be displayed inline within the feed example page using an iframe. Previously, the example had to be opened in a separate page.

Also includes some editorial revisions and updates.

Co-authored-by: Andrea N. Cardona
Co-authored-by: Matt King
Co-authored-by: Mike Pennisi
Co-authored-by: Howard Edwards

View commit 0e40c0d


Infrastructure: Update skipto.js to fix shortcut key bug for non-english keyboard layouts (pull #2975)

By Jon Gunderson on May 22, 2024

  • Disables shortcut key for skipto when focus is on a text input.
  • When menu opens, prevents hover from triggering focus change.
  • Remove hover styling when pointer leaves menu.

View commit 504391a

Copy link

netlify bot commented May 23, 2024

Deploy Preview for aria-practices ready!

Name Link
🔨 Latest commit e2b1d18
🔍 Latest deploy log https://app.netlify.com/sites/aria-practices/deploys/664f6c0bf7333400087848c3
😎 Deploy Preview https://deploy-preview-327--aria-practices.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@howard-e
Copy link
Contributor Author

howard-e commented May 23, 2024

Drafting until confirmation can be had on w3c/aria-practices#3026 being ready for today's publication.

@howard-e
Copy link
Contributor Author

@shawna-slh is there a cut off time for when you could perform the publication?

@shawna-slh
Copy link
Contributor

If it is simple content updates, then I can do until 4:30pmCT. If there are potentially problematic things that might break the site deploy, I'd be hesitant to do after 12:00noonCT since Remi will be done for the day.

NOTE: For timely communications, please ping me in Slack (or IRC or WhatsApp or text) as I won't see e-mail notifications of comments here right away.

@howard-e
Copy link
Contributor Author

howard-e commented May 23, 2024

If it is simple content updates, then I can do until 4:30pmCT. If there are potentially problematic things that might break the site deploy, I'd be hesitant to do after 12:00noonCT since Remi will be done for the day.

Yep, this PR does contain only simple content updates. 1 additional page has been added but it follows the pattern of other similar pages in the About section, so it should raise no issues. And the incoming change being requested here only affects a single existing file as well.

cc @mcking65 @a11ydoer on the above time constraints if we would like to still include w3c/aria-practices#3026 today.

NOTE: For timely communications, please ping me in Slack (or IRC or WhatsApp or text) as I won't see e-mail notifications of comments here right away.

Thank you for the reminder, will do!

@mcking65
Copy link
Contributor

@shawna-slh

Offline, we just started a discussion about whether to wait till Tuesday b/c of timing of AT support table update dependencies on the aria-at side.

@mcking65
Copy link
Contributor

I merged w3c/aria-practices#3026

@howard-e howard-e changed the title For publication / deploy on Thursday May 23, 2024 For publication / deploy on Tuesday May 28, 2024 May 23, 2024
@howard-e
Copy link
Contributor Author

howard-e commented May 23, 2024

Offline, we just started a discussion about whether to wait till Tuesday b/c of timing of AT support table update dependencies on the aria-at side.

@mcking65 @shawna-slh I've updated the description of this PR to be a May 28 deploy request instead.

I merged w3c/aria-practices#3026

Thanks!

@shawna-slh
Copy link
Contributor

@howard-e This is currently set as draft. Is it ready for deploy/publication?

@howard-e howard-e marked this pull request as ready for review May 28, 2024 14:14
@howard-e
Copy link
Contributor Author

howard-e commented May 28, 2024

Offline, we just started a discussion about whether to wait till Tuesday b/c of timing of AT support table update dependencies on the aria-at side.

@mcking65 @a11ydoer the blocking deploy on the aria-at-app has now been done.

This is currently set as draft. Is it ready for deploy/publication?

@shawna-slh thanks for checking in! I've now marked this ready for publication.

@shawna-slh shawna-slh self-requested a review May 28, 2024 16:07
@shawna-slh
Copy link
Contributor

@remibetin - ready to publish. Thanks!

@a11ydoer
Copy link

@remibetin, please let me know if it has been published so I can confirm the changes. @mcking65

@remibetin
Copy link
Member

@a11ydoer I will publish in the next 30min.

@remibetin remibetin merged commit e87ccac into publication May 28, 2024
4 checks passed
@remibetin
Copy link
Member

@a11ydoer @mcking65 @howard-e These changes have been published!

cc @shawna-slh

@howard-e
Copy link
Contributor Author

Thanks @remibetin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants