-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: vc-jwt context #54
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a clear path forward on the @context
issue, allowing you to interoperate cleanly.
Might need some language around how to process if @context
is present in the jwt
agreed - we could add an issue and reference from this PR, or add to this - happy to take suggestions the top case i see there is for when multiple contexts are used and not suggested by a |
What happens if a context is used that breaks the implied context, for example, if I define a context that makes |
examples/vc-2.0/vc-jwt.jsonld
Outdated
"@type": "JwtVerifiableCredential", | ||
"vc:credentialSubject": { | ||
"@type": "JwtCredentialSubject", | ||
"jwt:iss": {"@id": "vc:issuer"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this stuff needs to be in the @context
, but I think the intention is clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made some adjustments - still working through a double check on n-quads bc json-ld is hard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 great demonstration of the concept
i believe there is an implied update in the core data model "Verifiable credentials define terms in a JSON-LD context at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand the intent of this PR and it may not be harmful but it also may not be helpful. It isn't necessary to apply a mapping to VC-JWTs to be able to successfully define and use them. Adding this to the spec might confuse some people into thinking that it is necessary or recommended.
Co-authored-by: Bumblefudge <[email protected]>
I'm not sure I understand the risk of confusion, is this about the word "implies"? Would it be more precise to mirror the language of the resolution recorded here and word it as a requirement for "bidirectional transformation" rather than an... implication? Happy to straw-man a more explicit (although verbose) version if anyone thinks it might be less confusing. |
I.e. If bidirectional transformation to RDF-based proof types is desired, implementers MUST use the content type Im happy to cease and desist if I'm misinterpreting what helpful looks like (having not been at the F2F), or continue bikeshedding with further input. |
This comment was marked as resolved.
This comment was marked as resolved.
@bumblefudge that topic is a whole nother can of worms. Intent on this PR is to get a starting point to demonstrate how to link a JWT using only registered and private claims back into the graph model and semantics afforded us by the core data model context. It could for sure, serve as a building block in helping towards the direction indicated by the wg |
We are not required to add this PR here, just showing that it is possible is enough. A few options:
I agree it could be confusing if not introduced carefully. |
Closing in favor of #56 |
I do not believe that this context is correct (as in where we want to end up), but i believe that it is a good start for discussion
Preview | Diff