-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shorten media type closes #45 #50
Conversation
I don't know of any conflicts with the So, in general, I'm supportive of this provided that we can be consistent. It's not a deal breaker if we can't be consistent in the end, but I think we should go for consistency over having short names in just one place simply because we're able to shorten it there. |
@dlongley -- Please carry your comment from here back to the issue #45 where I believe it should have been raised and discussed to completion before this PR was raised. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nce
@@ -658,7 +658,7 @@ <h2>Version 2</h2> | |||
</p> | |||
<section> | |||
<h2>Credential Metadata</h2> | |||
<p><a data-cite="rfc7519#section-5.1">typ</a> MUST use the content type <code>verifiable-credential+jwt</code>.</p> | |||
<p><a data-cite="rfc7519#section-5.1">typ</a> MUST use the content type <code>vc+jwt</code>.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YES PLEASE
The issue was discussed in a meeting on 2022-09-15
View the transcript2. VC-JWT.
Orie Steele: presentation about VC JWT, PRs, and take temperature of SD-JWT. Michael Prorock: Note these important things. Tend to see this between parties trying something out. Also see in developer docs that publish private claims with rules.. Orie Steele: Example from slide 91 PR #44. See github pull request vc-jwt#50. See github issue vc-jwt#53. Orie Steele: You can have properties in JSON. Everyone expects that they can be ignored if you don't understand them.. Manu Sporny: I missed this when reviewing PR 33. All of a sudden we made
Manu Sporny: massive -1. Believes this is the wrong thing to do.. Orie Steele: Would you prefer we call them credentials.
Joe Andrieu: We don't have an unsecured media type for a credential claim set.. Orie Steele: the cty property that has been adopted has a -1.1. The one shown here doesn't have this.. Joe Andrieu: I don't understand why we are talking about a credential claim set that are not a VC. Orie Steele: are you talking bout credential-claim-set versus credential+ld+json?. Joe Andrieu: definition of what a VC is is not what is at point. VC data model defines a VC but that is not this (slide).. Orie Steele: There is two parts of the spec to review together. First is the definition. Second is every normative statement that is a requirement. Those are what a VC is.. Joe Andrieu: Do you believe the stuff on the right meet those requirements?. Orie Steele: Lets start with the definition. Ivan Herman: say the say thing as Joe. The right hand side is not what we defined in the VC data model, except for the context which is optional.. Dave Longley: Agree with manu, Joe and ivan on this. Getty very confused on the processing rules to understand this. Would have to go back to some mapping rules which I though we were moving away from.
Dave Longley: looks complicated and out of scope for the group. Michael Jones: this came out of a desire to have VC-JWT to be simpler than in 1.1.
Michael Jones: It was the view of the editors to have no mapping rules. So we created for v2 a native JWT representation of VC. No question that they are credentials and verifiable. They don't use all the claims from the VC data mode..
Michael Jones: this makes it simpler than 1.1. It admits the mapping was a mistake and that we should use native claims directly. Michael Prorock: a couple ways this discussion can go. Initially read the definition. Pasted into the minutes..
Michael Prorock: Read from section 1.1 in VC-JWT. Relation to the VC data model. Defines encoding rules to covert. Defines how to make use of VC-JWT specific claim names..
Michael Prorock: There are stuff not covered by registered claim names. These are the things that make VCs VCs.. Manu Sporny: Normative language in the spec and these are not in the VC-JWT example..
Manu Sporny: We have a conformance specification and states clearly what forms a conformant document..
Manu Sporny: The thing on the right is not any of these things..
Manu Sporny: not in our charter to do this. unless we want to come up with mappings again..
Gabe Cohen: What will it take to make more sections normative to prevent lawyering.. Andres Uribe: My interpretation. Normative pieces are: must be a context. must have a credential subject. When manu referred to mappings is this what you mean?. Manu Sporny: yes. Andres Uribe: If we step away from JSON and support protos. What does that mean for names? (protobufs).
Orie Steele: VC-JWT today describes the mapping from vc-credential+ld+json to a JWT. These rules say that properties can be omitted that are required in the core data model.
Orie Steele: implemented 1.1 VC-JWT and 1.1 data integrity. mapping problem in 1.1 was a real problem..
Orie Steele: in 2.0 we described 1.1 better. We also gave unique names to the content. We should make arguments clear as this is the beginning of a rational debate..
Orie Steele: Concerned that it may be pigeonholed into a dead end if we can talk about binary ....
Orie Steele: intention is to clearly communicate what working group members want..
Michael Jones: agree with co-editor (Orie).. Michael Prorock: Note that this is still a draft. Merging 44 doesn't mean the workgroup has done this.. Manu Sporny: We have mentioned binary expression of VC multiple times. This exists today as CBOR-LD and it is deployed and working. These arguments about binary are not convincing at all. That mechanism does do mapping leveraging the context..
Manu Sporny: if we have a different context for a JWT you could keep the JWT names and there would be an automated mapping because of the context the JWT people can ignore that would reconcile this method..
Manu Sporny: normative statements in the document are not satisfied. Just because we merged doesn't mean we agreed..
Joe Andrieu: I don't think this was merged with consensus..
Dave Longley: Agree with Joe. I dont think that this limits us to add more in version 3..
Dmitri Zagidulin: discuss mprorocks early question. What would the right side have to look like.
Orie Steele: we've been talking about data integrity and JWT as the only ways to secure the core data model - in 1.1 there was this other thing we talked about - CL signatures and other things. That existed back then, there was similar questions about whether it was or not a Verifiable Credential. Historical context, not new that we've had trouble determining whether something is a verifiable credential..
David Waite: Just wanted to clarify something... MikeP said
David Waite: one of the requirments we could have is it has to be a URL with same semantics... difference between binary and native formats... when you talk about CBOR as a compression algorithm in a QR Code, if you talk about IOT devices as json or RDF processing model, but they need to include URDNA, it becomes a bit untenable, wont work for some deployments, not enough physical size.. Michael Prorock: lead to possible proposal - if we can reliable go from one format into a VC-compliant document, thats ok then to say "this is a VC". Some of this has been presented before - but we could define a vocabulary that takes in VC data model and then defines the terms that have a direct correspondence in a JWT, and uses them as defined by the context in verifiable credentials - must downselect certain capabilities.
Michael Prorock: the advantage is that we can have things which just look like a normal JWT - possibly with additional required properties, that can always go back to VC data model. It also sets up from a CBOR standpoint to use those existing mappings for already defined claims, and use those existing encodings.
Michael Prorock: implicit XSLT, but dislike it compared to other options such as not having semantics about things in core VC..
Michael Jones: I apreciate efforst to engineer a path forward, helpful to have face-to-face meetings to incubate such ideas. Could live with that mapping - that cynical Mike could then say you could define a mapping that concrete implementations choose not to use (to VC data model).. David Chadwick: party A has a document in the VC Data Model, has the subject and optional attributes - they put a proof on it - JSON-LD, JWT proof. Pass it to party B, strips off that proof, passes it back to A. They will end up with the same document they started with nods.
David Chadwick: We have shown this between issuers and verifiers JFF plugfest - ran through schema rules and conformed to VCDM. Put the entire VCDM and put it into the VC claim.
Manu Sporny: +1 , value in certain kinds of mapping. Previous mapping did not work out well. Two proposals - David Chadwick's approach is to copy without omitting, Mike Prorock's suggestion is to define a mapping for fields to and from claims set. Concerned that translations have problems, such as dates and issuer strings. You would end up with something that looks more like a JWT. Feel David Chadwick's approach is cleaner due to separations. Samuel Smith: make a modified proposal - like the idea of implied
Samuel Smith: you would not get the benefit of the intermediate representation. Been arguing we should have a layered approach, the cryptographic operations are distinct from the usability of the claim set. NIST does a good job where they separate IAL and AAL (assurance levels). When we talked yesterday about the issuer binding etc assurances, we are using that NIST model where you have assurance levels. What we didn't say is what authenticator assurance[CUT]. David Chadwick: point out that mike's proposal is flawed from a security perspective - the issuance and expiry of the credential are not the same of the credential are the same as the JWT. The previous example of the driving license. If you do mappings between them, you will get in trouble..
Michael Prorock: doesn't disagree with David - there are mappings between some of the registered claims, and how you can do those with a JWT - it is not 1:1. There is this notion that certain other data fields would be necessary there. This gives us the opportunity to identify those, possibly add new claims if needed. Provides us a way to reconcile these two things..
Joe Andrieu: defer some comments on optional
Joe Andrieu: if Michael Prorock: if you go from a VC in JSON-LD to a VC-JWT,.... Joe Andrieu: so I think it may fail that black box. David Chadwick: think I know how to solve this issue - the claims about the subject and in the VCDM are distinct from the claims used for the proof.
David Chadwick: a number of incidents where we talk about claims of the VC that are actually metadata of the credential, has its own metadata such as its serial number or issuance data.
David Chadwick: think JFF got it right when they put the certificate identifier as the credential identifier, each proof would have a different identifier but the credential data would have the same number.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Open for 2 weeks, no objections, merging. |
I do not concur that there were no objections, nor with merging this PR, nor with closing issue #45, as this PR was created before the issue was discussed to completion. Additionally, AT LEAST, Proposal to Merge PR #50 and thereby close Issue #45 should have been on a telecon agenda, and there should have been a +1/0/-1 polling, before such merge & close. |
Since this pull request has been reverted. Please indicate your support for shortening media types once again on #61 |
Preview | Diff