Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Security Considerations Section #100

Merged
merged 5 commits into from
Dec 14, 2023
Merged

Add Security Considerations Section #100

merged 5 commits into from
Dec 14, 2023

Conversation

Wind4Greg
Copy link
Collaborator

@Wind4Greg Wind4Greg commented Nov 28, 2023 •
edited by pr-preview bot
Loading

This PR adds a security considerations section. This section has two subsections:

  1. Base Proof Security Properties -- The base proof is based on a BBS signature so we review its proven security properties (EUF-CMA and SUF-CMA) and point to the references where these are proven.
  2. Derived Proof Security Properties -- The derived proof is based on a BBS proof so we review the meaning of a "zero knowledge proof of knowledge" of a signature and point to references where this is proven and additional explanations.

Preview | Diff

@Wind4Greg Wind4Greg requested a review from tplooker as a code owner November 28, 2023 01:11
@Wind4Greg Wind4Greg requested a review from msporny December 7, 2023 19:58
@Wind4Greg Wind4Greg mentioned this pull request Dec 11, 2023
Closed
dlongley
dlongley approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know that we need as much math exposition as is here, but +1. Thanks!

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@msporny
Copy link
Member

msporny commented Dec 14, 2023

Editorial, multiple reviews, no changes requested, merging.

@msporny msporny merged commit 5f0f342 into w3c:main Dec 14, 2023
2 checks passed
@Wind4Greg Wind4Greg deleted the security branch December 15, 2023 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlongley dlongley dlongley approved these changes

@msporny msporny msporny approved these changes

@tplooker tplooker Awaiting requested review from tplooker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Wind4Greg @msporny @dlongley