Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added detailed lifecycle diagram and revised explanatory text details #624

Merged
merged 4 commits into from
May 25, 2019

Conversation

ken-ebert
Copy link
Contributor

@ken-ebert ken-ebert commented May 13, 2019

This replaces PR #577 . I have added a diagram and simplified the text to reflect the lack of implied ordering of actions.


Preview | Diff

Copy link
Member

@msporny msporny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a misplaced section tag is creating issues in the markup. Other than that, agree w/ the text... can't view the SVG file until I merge the PR in.

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@TallTed
Copy link
Member

TallTed commented May 14, 2019

Several minor tweaks to the text. I wish the SVG were visible in the preview. If it's as we drafted over the weekend, I'm probably fine with it ... but I must reserve final judgement.

@ken-ebert
Copy link
Contributor Author

@TallTed

Several minor tweaks to the text. I wish the SVG were visible in the preview. If it's as we drafted over the weekend, I'm probably fine with it ... but I must reserve final judgement.

I made some small adjustments in the same graphic file I shared with you previously. Again, I welcome your feedback. The link is below.

@msporny Anyone should be able to view the diagram at this link:
https://docs.google.com/drawings/d/1kOMAWPFVvN6LwwTJP-Mqx0xZtVY3ozoBk5MXYEnllCM/edit?usp=sharing

@David-Chadwick
Copy link
Contributor

Nice diagram. My only slight worry is that this presents the picture that VCs are designed to be swapped between holders multiple times, back and forth, without restriction, when in practice this is not going to be the case. Most physical VCs today are issued to the subject and kept by the subject. And work in ISO on electronic IDs and driving licenses is ensuring that the subject does not pass his/her VC onto another holder.

@TallTed
Copy link
Member

TallTed commented May 14, 2019

I think restriction of holder-to-holder handoffs is a protocol question. Checking whether the holder is "permitted" to be the presenter seems a verifier policy question. Such handoffs may and will happen, so the model must allow for it. I don't think anything in the current diagram indicates that such handoffs are necessary, only possible.

@David-Chadwick
Copy link
Contributor

I have a number of changes to suggest to this text as follows.

  1. Issuance must occur before any other actions involving this credential can occur. >
    Issuance always occurs before any other actions involving this credential.

  2. A holder presents one or more of its verifiable credentials to a verifier in a verifiable presentation. >
    A holder presents one or more of its verifiable credentials to a verifier, optionally inside a verifiable presentation.

  3. This should include checking the credential status for revocation of verifiable credentials. >
    This should include checking the credential status for revocation of the verifiable credentials.

  4. Verification occurs some time after a verifiable presentation. > null (i.e. delete)

  5. The simplest useful sequence of actions envisioned would be issue, present, and verify. >
    The most common sequence of actions are envisioned to be: issuer issues to subject, subject presents to verifier, and verifier verifies.

@ken-ebert
Copy link
Contributor Author

ken-ebert commented May 14, 2019

@David-Chadwick Do you have a suggested specific change to the diagram that I could make to communicate the exceptional rather than ordinary nature of transfers?

Your text suggestions look good. I will make the changes.

@David-Chadwick
Copy link
Contributor

If I were to change the diagram I would delete the top set of holders and turn the double headed arrow that points to them into a 3/4 circle arrow that points to holders underneath the top holder in the centre of the diagram.

@ken-ebert
Copy link
Contributor Author

Thank you @David-Chadwick for your suggested improvements to the text and diagram. I have revised the text and diagram to reflect your suggestions.

The updated diagram is located at the same link for review prior to the pull request being merged.: https://docs.google.com/drawings/d/1kOMAWPFVvN6LwwTJP-Mqx0xZtVY3ozoBk5MXYEnllCM/[email protected]&ts=5cd5b33d&actionButton=1

@ken-ebert ken-ebert requested review from msporny and TallTed May 14, 2019 20:48
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@TallTed
Copy link
Member

TallTed commented May 14, 2019

I've made several further changes to the diagram, and suggested several minor text tweaks. I think we're close, if not there, with these.

@ken-ebert
Copy link
Contributor Author

Thanks, Ted for your detailed review and suggestions. I think the diagram changes add clarity to the status check and the number of times actions can occur.

@msporny msporny merged commit 49d8789 into w3c:gh-pages May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants