Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"final holder" may not be "final" #577

Closed
wants to merge 2 commits into from
Closed

"final holder" may not be "final" #577

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d0addd
"final holder" may not be "final"
TallTed Apr 24, 2019
b1f6df9
Update index.html
TallTed Apr 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1820,24 +1820,24 @@ <h3>Lifecycle Details</h3>
<a>verifiable credentials</a> from <a>holders</a> for its supported actions.
</li>
<li>
The <a>issuer</a> issues a <a>verifiable credential</a> to the <a>holder</a>.
The <a>issuer</a> issues some <a>verifiable credential(s)</a> to the <a>holder</a>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issuer issues one or more verifiable credentials to the holder.

</li>
<li>
The <a>holder</a> might pass on its <a>verifiable credentials</a> to another
The <a>holder</a> might pass on its <a>verifiable credential(s)</a> to another
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The holder might pass on one or more of its verifiable credentials to another

<a>holder</a>.
</li>
<li>
The final <a>holder</a> presents its <a>verifiable credentials</a> to the
The <a>holder</a> presents its <a>verifiable credential(s)</a> to the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A holder presents one or more of its verifiable credentials to the

Note. Now that we have more than one holder we can no longer refer to "the" holder as it is ambiguous. Final holder was not ambiguous.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Final holder" was not ambiguous, but it implied a termination of holder-to-holder transfers was required for a holder to present a VC to a verifier, which requirement does not exist. As I noted in my earlier comment, "The" seems not to be appropriate for any of these bullets.

<a>verifier</a> in a <a>verifiable presentation</a>, requesting a supported
action.
</li>
<li>
The <a>verifier</a> <a>verifies</a> the authenticity of the
<a>verifiable presentation</a> and <a>verifiable credentials</a>.
<a>verifiable presentation</a> and <a>verifiable credential(s)</a>.
</li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous step had a holder passing to a verifier. So this step should be talking about the same holder and the same verifier. It makes no sense to talk about any holder or any verifier since they may not have communicated with each other. You are already talking about THE verifiable credentials and not any old VCs, so you are inconsistent. Furthermore the VP is optional so may not be there to be verified. Therefore this text should read

The verifier verifies the authenticity of the presented verifiable credentials
and the verifiable presentation containing them, if present.

<li>
The <a>verifier</a> <a>verifies</a> that the <a>holder</a> possesses the
<a>verifiable credentials</a>.
<a>verifiable credential(s)</a>.
</li>
<li>
The <a>verifier</a> decides whether to accept the <a>verifiable credentials</a>
Expand Down