Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add issue marker for extension point reservation discussion #1141

Merged
merged 2 commits into from
Jun 21, 2023

Conversation

OR13
Copy link
Contributor

@OR13 OR13 commented Jun 6, 2023

@OR13
Copy link
Contributor Author

OR13 commented Jun 6, 2023

See #1142

@OR13 OR13 mentioned this pull request Jun 6, 2023
3 tasks
@TallTed
Copy link
Member

TallTed commented Jun 7, 2023

"Holder binding." The misnomer that will not die.

Copy link
Member

@msporny msporny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the WG agreed to reserve confidenceMethod and point to the CCG work item? This issue marker deviates from how all of the other properties are being reserved (in that, confidenceMethod is not being reserved and the issue marker text makes a broad declaration about how properties are being reserved -- lowering the bar for property reservation). To be clear, I'd be fine w/ a lower bar, but this lower bar isn't where the WG landed.

Specific changes requested: align the way confidenceMethod is being reserved to the same way that the other properties are being reserved. (or, specify why confidenceMethod is being treated differently).

EDIT: It looks like PR #1141 is doing this, which obviates the need for this PR?

@decentralgabe
Copy link
Contributor

agree with @msporny I thought we had consensus on confidenceMethod. is there an anti-reserve list 🙃

@TallTed
Copy link
Member

TallTed commented Jun 12, 2023

Maybe we can agree to change all mentions of the misnamed holder binding, because it doesn't do any such thing, to something like authorized presenter list, which would do exactly what it says on the tin, i.e., it would provide verifiers with a list of holder identifiers against which the presenting holder's identifier could be tested, which I'm confident could be implemented in a privacy-preserving, crypto-involving manner?

@iherman
Copy link
Member

iherman commented Jun 14, 2023

The issue was discussed in a meeting on 2023-06-14

  • no resolutions were taken
View the transcript

1.1. Add issue marker for holder binding (pr vc-data-model#1141)

See github pull request vc-data-model#1141.

Michael Prorock: suggest we merge first, bikeshed naming and properties second.

Dave Longley: this is not bike shedding, its data modeling... in the information graph.
… id is a special property that has specific behavior.
… because of JSON-LD this could impact selective disclosure.
… its not just about picking a name.

Kristina Yasuda: ask for a special topic call if you need it.

Manu Sporny: its not bikeshedding, there are design considerations that effect JSON-LD selective disclosure.
… the SRI format is different, its not what SRI does... we should either align with SRI or align with something else.
… there are design considerations that effect selective disclosure in JSON-LD nquads.

Ivan Herman: See Subresource integrity spec:.

Manu Sporny: I am reviewing the PR now.
… people are requesting discussion.

Orie Steele: You're open to open a PR to follow best practice.

Orie Steele: AFAIK there is no bar, right now.

Orie Steele: no consensus on any bar afaik.

index.html Outdated Show resolved Hide resolved
Co-authored-by: Manu Sporny <[email protected]>
@OR13
Copy link
Contributor Author

OR13 commented Jun 20, 2023

@msporny please re-review, I have merged your change suggestion.

@msporny msporny changed the title Add issue marker for holder binding Add issue marker for extension point reservation discussion Jun 21, 2023
@msporny
Copy link
Member

msporny commented Jun 21, 2023

Editorial, multiple reviews, changes requested and made, no objections, merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants