-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add issue marker for extension point reservation discussion #1141
Conversation
See #1142 |
"Holder binding." The misnomer that will not die. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the WG agreed to reserve confidenceMethod
and point to the CCG work item? This issue marker deviates from how all of the other properties are being reserved (in that, confidenceMethod
is not being reserved and the issue marker text makes a broad declaration about how properties are being reserved -- lowering the bar for property reservation). To be clear, I'd be fine w/ a lower bar, but this lower bar isn't where the WG landed.
Specific changes requested: align the way confidenceMethod
is being reserved to the same way that the other properties are being reserved. (or, specify why confidenceMethod
is being treated differently).
EDIT: It looks like PR #1141 is doing this, which obviates the need for this PR?
agree with @msporny I thought we had consensus on |
Maybe we can agree to change all mentions of the misnamed |
The issue was discussed in a meeting on 2023-06-14
View the transcript1.1. Add issue marker for holder binding (pr vc-data-model#1141)See github pull request vc-data-model#1141. Michael Prorock: suggest we merge first, bikeshed naming and properties second. Dave Longley: this is not bike shedding, its data modeling... in the information graph. Kristina Yasuda: ask for a special topic call if you need it. Manu Sporny: its not bikeshedding, there are design considerations that effect JSON-LD selective disclosure.
Manu Sporny: I am reviewing the PR now. Orie Steele: You're open to open a PR to follow best practice.
|
Co-authored-by: Manu Sporny <[email protected]>
@msporny please re-review, I have merged your change suggestion. |
Editorial, multiple reviews, changes requested and made, no objections, merging. |
Preview | Diff