-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict JSON-LD expression to compact document form. #1050
Conversation
index.html
Outdated
<p> | ||
This specification restricts the usage of JSON-LD representations. JSON-LD <a | ||
href="https://www.w3.org/TR/json-ld/#compacted-document-form">compact document | ||
form</a> MUST be utilized for all expressions of the data model described by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the difference between "expression" and "representation" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Historically, I think we've tried to use "expression" to talk about something in the abstract (the data model) and "representation" to talk about something concrete (a serialization). I mixed them up here, and will change both to speak to "representation" -- does that work for you, @OR13 ?
The other option is we could say "serialization". All of this is a bit up in the air given that the JSON section in the spec, while it never really made any sense, makes even less sense now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer more explicit wording, not sure how the normative statement will be testable in its current form.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Will be improved by @OR13's suggestion and question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this suggested change, #1050 (comment)
But I would also take a change dropping verifiable
.
Ok, dropping @OR13 please re-review and confirm that this is the change you wanted. |
index.html
Outdated
This specification restricts the usage of JSON-LD representations of | ||
<a>credentials</a> and <a> presentations</a>. JSON-LD <a | ||
href="https://www.w3.org/TR/json-ld/#compacted-document-form">compact document | ||
form</a> MUST be utilized for all representations of the data model described by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"all representations of the data model"... this seems not correct based on F2F day 3 resolution.
We agreed that this only needs to be true for the "base media type" aka
application/credential+ld+json
or application/presentation+ld+json
Perhaps this PR changes the requirements for what constitutes a "mapping" to the base media type?
I would prefer for this MUST
to be bound to a specific content type, no abstract concepts that have no normative definition.
I feel similarly about other parts of the spec, such as @context
or validFrom
.
@msporny how can we make it clearer that "not all verifiable credential representations use JSON-LD compact form" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"all representations of the data model"... this seems not correct based on F2F day 3 resolution.
You're taking that phrase out of context. The stricture is on "all representations of the data model described by this specification" which I believe we expect to be few, so your concern seems premature to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolution #1: The base media type for the VCDM is credential+ld+json.
@context
is required (MUST) in the base media type; other media types MAY choose to include@context
. Serializations in other media types (defined by the VCWG) MUST be able to be transformed into the base media type. Another media type MUST identify if this transformation is one-directional or bi-directional. Bi-directional transformation MUST preserve@context
. Transformation rules MUST be defined, but not necessarily by this WG..
https://www.w3.org/2017/vc/WG/Meetings/Minutes/2023-02-16-vcwg#resolution1
I feel credential+ld+json
uses "compact form" would be a clearer way of saying the same thing.
Seems the intention is aligned with resolution, and data integrity proofs can indeed use "non compact form" for VCs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OR13 I get what you're saying and I think I agree with you. @TallTed you're technically correct, but this might be an area where we can be very specific without giving the impression that we're restricting media types that we didn't mean to restrict.
I'm waiting on the media types discussion to settle before applying the final wording here. We need to understand the outcome of the media type discussions before locking the wording in this section in, which should probably only apply to the ONE base media type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we would do well by rewording the sentence —
JSON-LD <a
href="https://www.w3.org/TR/json-ld/#compacted-document-form">compact document
form</a> MUST be utilized for all representations of the data model described by
— to —
JSON-LD <a
href="https://www.w3.org/TR/json-ld/#compacted-document-form">compact document
form</a> MUST be utilized for all JSON-LD representations of the data model described by
— if that is indeed what was intended (which I don't think it was).
Given that we're defining the base media type, named credential+ld+json
(or vc+ld+json
), to which all other representations must be losslessly transformable, I think it would be better to say —
JSON-LD <a
href="https://www.w3.org/TR/json-ld/#compacted-document-form">compact document
form</a> MUST be utilized for all representations of the data model in the base
media type, vc+ld+json (or credential+ld+json).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving only based on the resolution today, regarding vc+ld+json
.
The issue was discussed in a meeting on 2023-03-14
View the transcript2.3. Restrict JSON-LD expression to compact document form. (pr vc-data-model#1050)See github pull request vc-data-model#1050. Manu Sporny: This one, PR 1050, was just waiting on what we decided today. I'm not worried about this PR. |
The issue was discussed in a meeting on 2023-03-14 List of resolutions:
View the transcript1. Media types
|
Co-authored-by: Orie Steele <[email protected]>
9b68f82
to
e63c069
Compare
Editorial, multiple reviews, changes requested and made, no objections, merging. |
Addresses PR #779 by limiting JSON-LD expressions to compact document form.
Preview | Diff