-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add relatedResource
to VerifiablePresentation
#1265
Comments
I have since changed my mind based on the conversations at W3C TPAC; -1, new feature, not clear what the use case is. |
+1 excellent idea. |
I am of course fine with adding this property, which is indeed missing. But there is more, see below Here is what I think must be done (see also #1263 (comment)):
However, it turns out that the VCDM spec includes two more properties:
These two properties are not only missing from the vocabulary, but also missing from the context! Note that, for the I am happy to create a PR with all these changes, if we have an agreement. |
This feels like a new feature. Am I missing something? |
I think one question raised during TPAC WG mtg was "what use-cases relatedResource in presentations are not addressed by relatedResouce in credentials"
|
The issue was discussed in a meeting on 2023-09-14
View the transcript2.2. Add
|
I think it's likely a mistake to add arbitrary resources to a presentation. If the verifier didn't request it, it's going to be weird. If the verifier did request it, I think the likely path is as a VC, e.g., requesting a VC with a photo of the user and getting that VC is much more appropriate than arbitrarily shoving an image in the presentation. And how do request protocols handle requests for arbitrary data? Doing it outside the VC flow raises questions. How does the verifier ask for the right asset? What happens if you don't have it? These augmentations are potentially interesting, but right now, we haven't explored how we support it. I think this is too much of a new feature that isn't just a replication of what happens with VCs, it creates new questions and problems that need additional analysis and consideration. |
As also agreed at TPAC, I will submit soonish a PR taking care of #1265 (comment). Reading through the comments, I do not think there is a consensus on adding VP as a possible domain for related resource, so I propose to keep it for VC only for now. (It is easy to change that later if we decide to do so.) |
I think you may have missed some of the other discussions around this. The So the expectation is that protocols such as OID4VP will be expected to request VCs that are secured using VC-JOSE-COSE to be presented as values in the |
Removing |
suggest closing and tacking no action |
The issue was discussed in a meeting on 2023-11-15
View the transcript3.3. Add
|
After some debate with @dlongley, I've changed my mind (yet again) on this issue and propose a concrete use case for this feature:
That is, the argument for this feature is the same as for including it in To be clear, I don't think that I remain dubious to the use of I expect that @jandrieu will object to this proposal because of what he said above, and will suggest we provide something like a To summarize: Option ADefine Option BDefine |
@msporny, just a technical comment:
The term definition in the spec as well as the vocabulary item have been defined without any domain statement. I think that was intentional to make them usable on any object. I.e., this wish in option B has already been fulfilled 😀 |
@iherman wrote:
Not quite... :) more below.
We don't have Hrm, looks like we also don't have |
Yeah, I am very narrow-minded, and was looking at the vocabulary only. The JSON context is your baby :-) |
During the 2023-11-15 meeting (see above), the group requested that this issue be closed, and the discussion to be continued in two separate issues (extracted from this one). These issues have now been created:
So presumably this issue can be marked 'pending closed'. |
@dmitrizagidulin the issue has been marked as Pending Close last week. I would not consider Thanksgiving week as 'complete', so I would think the required pause should end next week, at which time @brentzundel can close the issue. |
Originally discussed in:
domain
andrange
correct for all properties in data model? #1263 (comment)This would allow a VerifiablePresentation or VerifiableCredential to point to "other graph nodes by id", instead of pointing to "VerifiableCredentialGraph" containers.
See also the discussion on the different between the two here:
#1240
The text was updated successfully, but these errors were encountered: