Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent failing on missing vpVerifier info. #138

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

BigBlueHat
Copy link
Member

No description provided.

Copy link
Contributor

@aljones15 aljones15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I'm assuming this was tested. You could use ?. as a chain if you wanted here, but the && is fine. Optional chaining is documented here: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Optional_chaining

Copy link
Collaborator

@PatStLouis PatStLouis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would work, we can always revert if it has adverse effects

@BigBlueHat BigBlueHat merged commit 3a50329 into main Nov 12, 2024
2 checks passed
@BigBlueHat BigBlueHat deleted the fix-vpVerifier-required branch November 12, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants