Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify to use multibase representation of the base64url algorithm. #179

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

PatStLouis
Copy link
Contributor

@PatStLouis PatStLouis commented Oct 13, 2024

This adds specific instructions on the generate/expand bitstring algorithms to use multibase base64url instead of just base64url to be consistent with the data model section.

addresses #178


Preview | Diff

This adds specific instructions on the generate/expand bitstring algorithms to use multibase base64url instead of just base64url to be consistent with the data model section.
@iherman
Copy link
Member

iherman commented Oct 14, 2024

@PatStLouis I know that the change is not really substantial, but that is because I am involved with some of the details, but a general reviewer may not be so lenient. To avoid any issues, it would be better if, this time, you would follow the patent disclosure procedure; I guess you have received a notification from the system. Just to avoid unnecessary discussions...

Thanks

@msporny msporny added editorial CR1 This item was processed during the first Candidate Recommendation phase. labels Nov 18, 2024
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@msporny
Copy link
Member

msporny commented Nov 18, 2024

Editorial, multiple reviews, changes requested and made, no objections, merging.

@msporny msporny merged commit aed0a94 into main Nov 18, 2024
1 of 2 checks passed
@msporny msporny deleted the add-multibase-to-bitstring-algorithms branch November 18, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR1 This item was processed during the first Candidate Recommendation phase. editorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants