Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add privacy consideration section about Multistatus Correlation. #117

Merged
merged 3 commits into from
Jan 13, 2024
Merged

Add privacy consideration section about Multistatus Correlation. #117

merged 3 commits into from
Jan 13, 2024

Conversation

msporny
Copy link
Member

@msporny msporny commented Dec 29, 2023 •
edited by pr-preview bot
Loading

This PR is an attempt to address issue #86 by adding a privacy considerations section about Multistatus Correlation.

Preview | Diff

@msporny msporny requested a review from mprorock as a code owner December 29, 2023 22:13
@msporny msporny mentioned this pull request Dec 29, 2023
Closed
David-Chadwick
David-Chadwick suggested changes Dec 30, 2023
View reviewed changes
Copy link
Contributor

@David-Chadwick David-Chadwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this explanation is still rather vague and not that enlightening to people.
For example, why would an entity appear in a status list at different points in time with different statuses?

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
dlongley
dlongley approved these changes Dec 30, 2023
View reviewed changes
Copy link
Contributor

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to David's grammatical fixes.

TallTed
TallTed approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with @David-Chadwick's previously suggested changes

msporny
msporny commented Jan 2, 2024
View reviewed changes
index.html Outdated Show resolved Hide resolved
@msporny
Copy link
Member Author

msporny commented Jan 13, 2024

Editorial, multiple reviews, changes requested and made, no objections, merging.

@msporny msporny merged commit dbe2e53 into main Jan 13, 2024
2 checks passed
@msporny msporny deleted the msporny-multistatus branch January 13, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@David-Chadwick David-Chadwick David-Chadwick requested changes

@KDean-GS1 KDean-GS1 KDean-GS1 approved these changes

@TallTed TallTed TallTed approved these changes

@longpd longpd longpd approved these changes

@dlongley dlongley dlongley approved these changes

@npdoty npdoty Awaiting requested review from npdoty

@jandrieu jandrieu Awaiting requested review from jandrieu

@dmitrizagidulin dmitrizagidulin Awaiting requested review from dmitrizagidulin

@andresuribe87 andresuribe87 Awaiting requested review from andresuribe87

@brianorwhatever brianorwhatever Awaiting requested review from brianorwhatever

@decentralgabe decentralgabe Awaiting requested review from decentralgabe

@brentzundel brentzundel Awaiting requested review from brentzundel

@seabass-labrax seabass-labrax Awaiting requested review from seabass-labrax

@mprorock mprorock Awaiting requested review from mprorock mprorock is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@msporny @dlongley @longpd @TallTed @David-Chadwick @KDean-GS1