Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note specifying that issuer might be different for status lists. #103

Merged
merged 4 commits into from
Jan 13, 2024

Conversation

msporny
Copy link
Member

@msporny msporny commented Dec 27, 2023

This PR attempts to address issue #7 by stating that the issuer of the original VC and the issuer of the status list VC might not be the same entity.


Preview | Diff

Copy link
Contributor

@David-Chadwick David-Chadwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subject to minor grammatical improvement

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated
Comment on lines 760 to 764
before utilizing the information contained in either credential for further
decision making purposes. Implementers are advised that the issuers of these
credential might be different in use cases where the original issuer of the
<a>verifiable credential</a> does not maintain a record of its validity.
</p>
Copy link
Member

@TallTed TallTed Dec 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
before utilizing the information contained in either credential for further
decision making purposes. Implementers are advised that the issuers of these
credential might be different in use cases where the original issuer of the
<a>verifiable credential</a> does not maintain a record of its validity.
</p>
before using the information contained in either credential for further
decision making purposes. Implementers are advised that the issuers of these
credentials might differ, such as when the original issuer of the
<a>verifiable credential</a> does not maintain a record of its validity.
</p>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 612b477.

@msporny
Copy link
Member Author

msporny commented Jan 13, 2024

Editorial, multiple reviews, changes requested and made, no objections, merging.

@msporny msporny merged commit 49ccd08 into main Jan 13, 2024
1 of 2 checks passed
@msporny msporny deleted the msporny-issuer-validation branch January 13, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants