Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the factory as available on window to window.trustedTypes. #177

Closed
koto opened this issue Jun 1, 2019 · 2 comments · Fixed by #205
Closed

Rename the factory as available on window to window.trustedTypes. #177

koto opened this issue Jun 1, 2019 · 2 comments · Fixed by #205
Assignees
@mikesamuel
Labels
polyfill spec
Milestone
v1

Comments

@koto
Copy link
Member

koto commented Jun 1, 2019

The spec trend is now to start with lowercase, so window.trustedTypes instead of window.TrustedTypes.

We should perform the rename as the last step after building + speccing all existing features, such that window.trustedTypes has stable features, unlike the current API that is under active development.

Note to authors: Please feature check before using the API i.e. check that window.TrustedTypes.createPolicy exists before calling it.
@koto koto added this to the v1 milestone Jun 24, 2019
@koto koto added the spec label Jun 24, 2019
@mikesamuel mikesamuel self-assigned this Jul 3, 2019
@mikesamuel
Copy link
Collaborator

Re the polyfill, I wonder whether making it es-shim API compatible would ease some of these migration issues.

@koto koto added the polyfill label Jul 17, 2019
@koto koto mentioned this issue Aug 8, 2019
Merged
@koto koto closed this as completed in #205 Aug 8, 2019
koto added a commit that referenced this issue Aug 8, 2019
@koto
Renamed window.TrustedTypes to window.trustedTypes (#205)

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 09541BBFF0C4C795
Learn about vigilant mode
84aedb6 
Fixed #177.

The polyfill will copy existing (i.e. native) window.TrustedTypes to window.trustedTypes.

Please use window.trustedTypes or (window.trustedTypes || window.TrustedTypes) from now on.
@koto
Copy link
Member Author

koto commented Aug 8, 2019

Chrome implementation tracked in https://bugs.chromium.org/p/chromium/issues/detail?id=991944.

@Siegrift Siegrift mentioned this issue Sep 3, 2019
Merged
9 tasks
@engelsdamien engelsdamien mentioned this issue Oct 2, 2019
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikesamuel mikesamuel

Labels
polyfill spec
Projects
None yet
Milestone
v1
Development

Successfully merging a pull request may close this issue.

Renamed window.TrustedTypes to window.trustedTypes koto/trusted-types
2 participants
@koto @mikesamuel