Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(examples/multi-spec): how to set secrets, avoid push conflicts #77

Merged
merged 3 commits into from
Jun 3, 2021

Conversation

tidoust
Copy link
Member

@tidoust tidoust commented Jun 3, 2021

This adjusts the documentation for a multi-documents repository to clarify how to pass Echidna tokens per document (see #55), and to highlight the possible need to serialize jobs (at least until #58 gets addressed).

This adjusts the documentation for a multi-documents repository to clarify how
to pass Echidna tokens per document (see w3c#55), and to highlight the possible
need to serialize jobs (at least until w3c#58 gets addressed).
@tidoust
Copy link
Member Author

tidoust commented Jun 3, 2021

Build fails because ReSpec wants to process the bits of code I put in the prose. How can I prevent that?

More precisely, I can prevent ReSpec processing with a backslash ${{\ foo }}, but the backslash would then appear in the markdown version of the doc...

docs/examples.md Outdated Show resolved Hide resolved
@sidvishnoi
Copy link
Member

More precisely, I can prevent ReSpec processing with a backslash ${{\ foo }}, but the backslash would then appear in the markdown version of the doc...

Lets go with that for now. I'll figure out a fix later.

@sidvishnoi
Copy link
Member

sidvishnoi commented Jun 3, 2021

@marcoscaceres We should probably add a check in ReSpec to not do the ${{ term }} expansion if it's wrapped in a <code>. WDYT?
I faced this problem in https://respec.org/docs/src.html also (ended up using a zero-width space hack there - added on include, removed in postProcess).

@sidvishnoi sidvishnoi changed the title Improve documentation on multi-documents repo docs(examples/multi-spec): how to set secrets, avoid push conflicts Jun 3, 2021
Copy link
Member

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tidoust!

@sidvishnoi sidvishnoi merged commit 3c8cddc into w3c:main Jun 3, 2021
github-actions bot added a commit that referenced this pull request Jun 3, 2021
)

SHA: 3c8cddc
Reason: push, by @sidvishnoi

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@marcoscaceres
Copy link
Member

marcoscaceres commented Jun 4, 2021

@marcoscaceres We should probably add a check in ReSpec to not do the ${{ term }} expansion if it's wrapped in a <code>. WDYT?

That probably wouldn't work, e.g.,:

Someone could do <code>{{ whatver/thing }} = "ffs"</code>, then blah blah.. 

We should use {{\ as the escape hatch, as we do with other things.

@tidoust
Copy link
Member Author

tidoust commented Jun 4, 2021

We should use {{\ as the escape hatch, as we do with other things.

Which works well for the ReSpec version of the documentation. Problem is this documentation also exists as a pure Markdown file on GitHub, linked from the README, where {{\ is not an escape hatch, see first Note in:
https://github.com/w3c/spec-prod/blob/main/docs/examples.md#multiple-specs-in-same-repository

@marcoscaceres
Copy link
Member

Ah, I read it backwards :)

Yeah, this is why I think we should just fold everything into index.html. We are pointing everyone to that document anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants