-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security issues when used in combination with other APIs #193
Comments
This looks like sensor-specific bug, any reason to have it open in the Generic Sensor? I listed some ALS-related things here. |
It's not. The idea that risk can increase because of a specific combination of APIs is generic. |
Oh, rightly so. Sorry I am actually signalling the issue for a while now. Happy we're taking it here. So short thing: probably difficult to make an exhaustive list :) |
We shouldn't be making that list (as it'll evolve over time). Just describing the threat. |
this case is addressed in a dedicated ALS issue
this case is addressed with Loosing Focus mitigation strategy This issue looks too generic to handle it: the list of possible combinations with other APIs is endless. |
I agree. The known attack vectors have now been documented and mitigated, so I'd be fine closing this issue (this issue was opened as a response to my verbal feedback at the WG teleconference). If we are made aware of new combinations of APIs that could be used for malicious purposes we should open a new topic-specific issue. |
I would only add that it's difficult to comply such a list. Maybe include something "general" in the generic sensors API text? Would it make sense to include a "data exfiltration" point there? |
@lknik, concrete suggestions welcome. |
Something along these:
Note, there are a number of sensors that could come to mind here. |
I feel that is too generic to be useful for implementers. In my opinion, a better approach is to be specific, and define the concrete threats in concrete sensor specifications similarly to the Ambient Light Sensor: https://w3c.github.io/ambient-light/#security-and-privacy I'd be inclined to close this issue with a note that we should document concrete attacks in applicable concrete specs. |
I think that @lknik 's warning is probably worth putting in the generic sensor spec - after all, a key security challenge posed by sensors is that they expose a new communication channel not protected by the SOP, so calling that out both to implementors and concrete-sensor spec writers seem relevant. |
I feel we should make https://w3c.github.io/sensors/#security-and-privacy as concise and actionable as possible to make it useful for implementers. Said differently, I'd like to avoid turning that section into an elaborate and ambiguous kitchen sink of unknowns. The risk of SOP violations is indeed a key concrete thing to flag out there. Re the proposed text. The S&P section contains the following text already:
There's redundancy with the proposed text, so it would need some rewording to better fit the overall flow. The SOP violations should be caught latest in https://w3ctag.github.io/security-questionnaire/#sop-violations, but since authors should consider this up front adding some links to https://w3c.github.io/sensors/#security would be a good thing to make concrete spec authors aware of threats, mitigations they inherit from the Generic Sensor API, and mitigations they need to consider on a case by case basis. |
Wouldn't it be actionable if you'd include that point and link to ALS spec as an "example"? ;) (but then it would end up in a cyclical reference;) ) |
Fix #193: Define extension spec Security & Privacy expectations
For example:
The text was updated successfully, but these errors were encountered: