Expose transferSize, encodedBodySize, decodedBodySize #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoavweiss
reviewed
Apr 14, 2021
index.html
Outdated
| <li><p>If <a>this</a>'s <a data-for="PerformanceResourceTiming">cache mode</a> is | ||
| "<code>local</code>", then return 0. | ||
| <li><p>Return <a>this</a>'s | ||
| <a data-for="PerformanceResourceTiming">timing info</a>'s [=fetch timing info/encoded body size=]. |
There was a problem hiding this comment.
If we add a fixed size here for the headers, we can close #238 (comment)
There was a problem hiding this comment.
Sure, I can do that, what value should I add?
index.html
Outdated
| <li><a>Setup the resource timing entry</a> for |entry|, given |initiatorType|, |requestedURL| and | ||
| |timingInfo|. | ||
| <li><a>Setup the resource timing entry</a> for |entry|, given |initiatorType|, |requestedURL|, | ||
| |timingInfo|, and the empty string or "<code>local</code>" |cacheMode|. |
There was a problem hiding this comment.
If we're just passing |cacheMode|, I think you can drop the "empty string or local" part
yoavweiss
approved these changes
Apr 14, 2021
index.html
Outdated
| <li><a>Setup the resource timing entry</a> for |entry|, given |initiatorType|, |requestedURL| and | ||
| |timingInfo|. | ||
| <li><a>Setup the resource timing entry</a> for |entry|, given |initiatorType|, |requestedURL|, | ||
| |timingInfo|, |cacheMode|. |
|
PR requests addressed. Can merge? |
annevk
pushed a commit
to whatwg/fetch
that referenced
this pull request
Apr 21, 2021
And hand processResponseDone a response. Resource Timing PR: w3c/resource-timing#266. Closes #1201. Follow-up: #1215.
This was referenced May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
transferSize is based on the cache mode of the resource.
Closes #238
Preview | Diff