Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change most ednotes to issue markers, and remove some closed issues. #115

Merged
merged 3 commits into from
Jun 9, 2023
Merged

Change most ednotes to issue markers, and remove some closed issues. #115

merged 3 commits into from
Jun 9, 2023

Conversation

gkellogg
Copy link
Member

@gkellogg gkellogg commented Jun 7, 2023 •
edited by pr-preview bot
Loading

@gkellogg gkellogg requested review from dlongley and yamdan as code owners June 7, 2023 20:56
yamdan
yamdan approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@yamdan yamdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gkellogg , I just added a few comments.

spec/index.html Outdated Show resolved Hide resolved
spec/index.html Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
@gkellogg @yamdan
Update spec/index.html
330aca2 
Co-authored-by: Dan Yamamoto <[email protected]>
@iherman iherman self-requested a review June 8, 2023 06:52
iherman
iherman approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@iherman iherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that "proposed closing" marked issues, as well as issue 87 and 88 should be removed, too.

@gkellogg gkellogg merged commit be06a2b into main Jun 9, 2023
@gkellogg gkellogg deleted the cleanup-notes-issues branch June 9, 2023 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yamdan yamdan yamdan approved these changes

@iherman iherman iherman approved these changes

@dlongley dlongley dlongley approved these changes

Assignees
No one assigned
Labels
spec:editorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gkellogg @dlongley @iherman @yamdan