Meta: address xref issue #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently ReSpec does not support this.
annevk
requested review from
asutherland,
beverloo,
marcoscaceres and
saschanaz
saschanaz
approved these changes
Nov 19, 2024
| The <dfn>json()</dfn> method steps are to return the result of <a>parsing JSON bytes to a | ||
| JavaScript value</a> given [=this=]'s [=bytes=]. | ||
| The <dfn>json()</dfn> method steps are to return the result of [=parse JSON bytes to a | ||
| JavaScript value|parsing JSON bytes to a JavaScript value=] given [=this=]'s [=bytes=]. |
There was a problem hiding this comment.
While approving, I thought this should just work on ReSpec too? cc @sidvishnoi
There was a problem hiding this comment.
It's relatively new that it works in Bikeshed. As this doesn't really block the other PRs in terms of preview or reviewability, I can wait a bit to see what @sidvishnoi says.
There was a problem hiding this comment.
This is based on textVariations (based on Bikeshed itself, but maybe needs some updates now). It can only do these transformations at the end of string (if it was "do the parse", it could have become "do the parsing").
Not planning to support transformations at the start any time soon though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently ReSpec does not support this.
Preview | Diff