Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Automation section after w3c/sensors#470 #57

Merged
merged 5 commits into from
Oct 26, 2023

Conversation

JuhaVainio
Copy link
Contributor

@JuhaVainio JuhaVainio commented Oct 25, 2023

The Automation section in the Generic Sensor API specification was rewritten and several terms and concepts have changed.

This commit adapts the Proximity Sensor spec to the changes:

  • Remove references to "mock sensor type", "mock sensor reading values" and the "MockSensorType" enum.
  • Define an entry in the per-type virtual sensor metadata map whose key is what used to be the "proximity" entry in MockSensorType and an appropriate virtual sensor metadata entry.

This is enough to integrate properly with the Generic Sensor spec and allow Proximity virtual sensors to be created and used.

Fixes #56.


Preview | Diff

The Automation section in the Generic Sensor API specification was rewritten and several terms and concepts have changed.

This commit adapts the Proximity Sensor spec to the changes:

Remove references to "mock sensor type", "mock sensor reading values" and the "MockSensorType" enum.
Define an entry in the per-type virtual sensor metadata map whose key is what used to be the "proximity" entry in MockSensorType and an appropriate virtual sensor metadata entry.
This is enough to integrate properly with the Generic Sensor spec and allow Proximity virtual sensors to be created and used.

Fixes w3c#56.
@JuhaVainio JuhaVainio requested a review from rakuco October 25, 2023 08:12
index.bs Outdated Show resolved Hide resolved
index.bs Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
@rakuco
Copy link
Member

rakuco commented Oct 25, 2023

Remove references to "mock sensor type", "mock sensor reading values" and the "MockSensorType" enum. Define an entry in the per-type virtual sensor metadata map whose key is what used to be the "proximity" entry in MockSensorType and an appropriate virtual sensor metadata entry. This is enough to integrate properly with the Generic Sensor spec and allow Proximity virtual sensors to be created and used.

This should be formatted as a list here and in the commit message.

Typo fixes.

Changed handling of "key" from map to list.

Changed "key" to "keys".

Use "get a property" operation for "near".
@JuhaVainio
Copy link
Contributor Author

Remove references to "mock sensor type", "mock sensor reading values" and the "MockSensorType" enum. Define an entry in the per-type virtual sensor metadata map whose key is what used to be the "proximity" entry in MockSensorType and an appropriate virtual sensor metadata entry. This is enough to integrate properly with the Generic Sensor spec and allow Proximity virtual sensors to be created and used.

This should be formatted as a list here and in the commit message.

Done

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
Keys was incorrectly defined as map and not as list.

Defined index for keys which is passed to "parse single-value number reading".

Typo fix in variable.
Copy link
Member

@rakuco rakuco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with a couple of nits

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
Added backticks to "near" when it represents text.
index.bs Outdated Show resolved Hide resolved
Copy link
Member

@rakuco rakuco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still lgtm
@anssiko can you merge this PR?

Copy link
Member

@anssiko anssiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JuhaVainio and @rakuco!

@anssiko anssiko merged commit 1be5160 into w3c:main Oct 26, 2023
1 check passed
github-actions bot added a commit that referenced this pull request Oct 26, 2023
…rences

SHA: 1be5160
Reason: push, by anssiko

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken references in Proximity Sensor
3 participants