-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite Automation section after w3c/sensors#470 #57
Rewrite Automation section after w3c/sensors#470 #57
Conversation
The Automation section in the Generic Sensor API specification was rewritten and several terms and concepts have changed. This commit adapts the Proximity Sensor spec to the changes: Remove references to "mock sensor type", "mock sensor reading values" and the "MockSensorType" enum. Define an entry in the per-type virtual sensor metadata map whose key is what used to be the "proximity" entry in MockSensorType and an appropriate virtual sensor metadata entry. This is enough to integrate properly with the Generic Sensor spec and allow Proximity virtual sensors to be created and used. Fixes w3c#56.
This should be formatted as a list here and in the commit message. |
Typo fixes. Changed handling of "key" from map to list. Changed "key" to "keys". Use "get a property" operation for "near".
Done |
Keys was incorrectly defined as map and not as list. Defined index for keys which is passed to "parse single-value number reading". Typo fix in variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with a couple of nits
Added backticks to "near" when it represents text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still lgtm
@anssiko can you merge this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @JuhaVainio and @rakuco!
…rences SHA: 1be5160 Reason: push, by anssiko Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
The Automation section in the Generic Sensor API specification was rewritten and several terms and concepts have changed.
This commit adapts the Proximity Sensor spec to the changes:
This is enough to integrate properly with the Generic Sensor spec and allow Proximity virtual sensors to be created and used.
Fixes #56.
Preview | Diff