Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing #341 #342 and #343 #345

Merged
merged 6 commits into from
Aug 16, 2023
Merged

Addressing #341 #342 and #343 #345

merged 6 commits into from
Aug 16, 2023

Conversation

simontWork
Copy link
Contributor

  • Added definitions of HDR, SDR, PQ, HLG and stop
  • Updated text about narrow range image formats
  • Updated removing TV specific terminology
  • Fixed ITU-T Supplement 19 link
  • Added note about calculation of MaxFALL and MaxCLL for animated PNG

Once we're happy with the text, still need to:

  • Link to definitions from main text

added author
Updated ITU Supplement 19 link to latest
Changed text as per issue #342
Added definitions mentioned in #343
SDR is being used instead of BT.709
can be derived from cICP chunk formats. Specific examples of its most common use-cases
for both HDR and SDR are available in [[ITU-T-Series-H-Supplement-19]].</p>
on its inherent capabilities. The mDCv chunk should be included for PQ
images. It is less common for other image formats but may be included. Color Primaries and White Point characteristics
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any other examples besides absolute luminance, display-referred, BT.2100 PQ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe @chrisn was aware of cases where mDCv is useful in SDR cases. Chris Needham, can you confirm?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that was me ... perhaps @digitaltvguy?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you're right. Sorry.

@@ -3898,7 +3934,7 @@ <h2><span class="chunk">mDCv</span> Mastering Display Color Volume</h2>

<aside class="example">
Example <span class="chunk">mDCv</span> chunk mastering display maximum
luminance using traditional SDR shading techniques at 100 cd/m<sup>2</sup>
luminance using traditional live television production techniques at 100 cd/m<sup>2</sup>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is okay as it is just an example, not a list of all use cases.


<p>A value of zero for either MaxCLL or MaxFALL means that the value is unknown or not currently calculable.</p>

<p class="note">An example where this will not be calculable is when creating a live animated PNG stream, when not all frames will be available to compute the values until the stream ends. The encoder may wish to use the value zero initially and replace this with the calculated value when the stream ends.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link
Collaborator

@ProgramMax ProgramMax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I'm late to this party.

I have some thoughts that we can put in a follow up commit.

Comment on lines +465 to +470
<dt id="3pq"><dfn>high dynamic range (HDR)</dfn>
</dt>

<dd>
an image format capable of storing images with a relatively low dynamic range of 5-8 stops. Examples include sRGB, Display P3, ITU-R BT.709
</dd>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.) I would prefer new IDs to not include the section number.

2.) The ID ("pq") doesn't match the term ("HDR") which doesn't match the definition ("low dynamic range"). Was this supposed to be a definition of SDR?

</dt>

<dd>
<a>transfer function</a> defined in ITU-R BT.2100 Table 5. (A relative scene-referred system)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can "ITU-R BT.2100 Table 5" be a link to the standard?

Comment on lines +619 to +624
<dt id="3sdr"><dfn>standard dynamic range (SDR)</dfn>
</dt>

<dd>
an image format capable of storing images with a relatively high dynamic range similar to or in excess of the human visual system's instantaneous dynamic range (~12-14 stops). PNG allows the use of 2 HDR formats, HLG and PQ.
</dd>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The term ("SDR") doesn't match the description ("high dynamic range").
I'm guessing this was meant to be a definition of HDR.

Comment on lines +626 to +627
<dt id="3stop"><dfn>stop</dfn>
</dt>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small formatting difference here of whitespace.

can be derived from cICP chunk formats. Specific examples of its most common use-cases
for both HDR and SDR are available in [[ITU-T-Series-H-Supplement-19]].</p>
on its inherent capabilities. The mDCv chunk should be included for PQ
images. It is less common for other image formats but may be included. Color Primaries and White Point characteristics
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe @chrisn was aware of cases where mDCv is useful in SDR cases. Chris Needham, can you confirm?

@ProgramMax
Copy link
Collaborator

Oh, it looks like many of the things I mentioned are fixed in #348

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants