Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the spec and explainer to clarify scope #221

Merged
merged 4 commits into from
May 2, 2024
Merged

Conversation

chrisn
Copy link
Member

@chrisn chrisn commented Mar 21, 2024

In response to #182, this clarifies that the goal for this API doesn't include arbitrary HTML content, and is scoped to HTMLVideoElement.


Preview | Diff

Copy link
Collaborator

@beaufortfrancois beaufortfrancois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the spec @chrisn!

We should also update the following line:

specification may allow PIP-ing arbitrary HTML content.

@chrisn
Copy link
Member Author

chrisn commented Mar 21, 2024

Thanks, I missed that!

@chrisn
Copy link
Member Author

chrisn commented Mar 21, 2024

@beaufortfrancois I added some proposed text in a316df1. How does this look?

Copy link
Collaborator

@beaufortfrancois beaufortfrancois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Use "Picture-in-Picture window" consistently
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
Copy link
Member

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few suggestions...

Co-authored-by: Marcos Cáceres <[email protected]>
@chrisn chrisn merged commit 8e59095 into main May 2, 2024
2 checks passed
@chrisn chrisn deleted the clarify-scope branch May 2, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants