Remove Page Visibility spec references #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakuco
reviewed
Dec 19, 2022
There was a problem hiding this comment.
Looking at https://html.spec.whatwg.org/multipage/interaction.html#page-visibility, {{visibilityState}} just returns the value of an internal slot that's set to either "hidden" or "visible".
Wouldn't it make more sense to say that "the PiP window visibility must not be taken into account by the user agent to determine if the system visibility state of a traversable navigable has changed" or something along those lines?
|
@rakuco Feedback addressed! Thank you :) |
github-actions bot
added a commit
that referenced
this pull request
Dec 19, 2022
SHA: e2c0312 Reason: push, by beaufortfrancois Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rakuco Thanks for filing #217
Hopefully this PR fixes it. Can you have a look?
Preview | Diff