Add PaintTimingMixin, exposing interoperable + implementation defined paint timestamps
#108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `paintTime` (the end of "update the rendering phase") - `presentationTime` (an optional implementation-defined timestamp) `startTime` returns `presentationTime`, or `paintTime` if `presentationTime` is not implemented. Currently this `PaintTimingMixin` is only included in `PerformancePaintTiming`, but it will be included in `ElementTiming`, `LargestContentfulPaint`, `PerformanceEventTiming`, and `PerformanceLongAnimationFrameTiming` as a follow up. This is based on a resolution at the web performance working group. Minutes: https://docs.google.com/document/d/1ZWAUJZBJUvSUyShvKXNEU-cuCe47jpgbR69ckWZUTfI/edit?tab=t.0#heading=h.kb3idfbysfg7 Closes #62
noamr
changed the title
PaintTimingMixin, which exposes two timestamps:PaintTimingMixin, exposing interoperable + implementation defined paint timestamps
clelland
reviewed
Nov 12, 2024
index.bs
Outdated
|
|
||
| The {{PaintTimingMixin/paintTime}} attribute's getter step is to return [=/this=]'s [=PaintTimingMixin/paint timing info=]'s [=paint timing info/rendering update end time=]. | ||
|
|
||
| The {{PaintTimingMixin/presentationTime}} attribute's getter step is to return [=/this=]'s [=PaintTimingMixin/paint timing info=]'s [=paint timing info/implementation-defined presentation time=] if it is not null; Otherwise zero. |
There was a problem hiding this comment.
Should this return undefined if the implementation does not support the presentationTime attribute? I thought that's why it was marked optional. Zero might be misinterpreted.
index.bs
Outdated
| 1. If |document|'s [=environment settings object/cross-origin isolated capability=] is false, then: | ||
| 1. Coarsen |paintTimingInfo|'s [=implementation-defined presentation time=] to the next multiple of 4 milliseconds, or coarser. | ||
| 1. Wait until the [=current high resolution time=] is |paintTimingInfo|'s [=implementation-defined presentation time=]. | ||
| 1. [=Queue a global task=] on the [=performance timeline task source=] given |document|'s [=relevant global object=] to |flushPaintTimings|. |
There was a problem hiding this comment.
This should probably read "to execute |flushPaintTimings|"
(or "call", "run", etc... but I think you need a verb.)
clelland
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
PaintTimingMixin, which exposes two timestamps:paintTime(the end of "update the rendering phase")presentationTime(an optional implementation-defined timestamp)startTimereturnspresentationTime, orpaintTimeifpresentationTimeis not implemented.Currently this
PaintTimingMixinis only included inPerformancePaintTiming, but it will be included inElementTiming,LargestContentfulPaint,PerformanceEventTiming, andPerformanceLongAnimationFrameTimingas a follow up.This is based on a resolution at the web performance working group. Minutes: https://docs.google.com/document/d/1ZWAUJZBJUvSUyShvKXNEU-cuCe47jpgbR69ckWZUTfI/edit?tab=t.0#heading=h.kb3idfbysfg7
Closes #62
Preview | Diff