Skip to content
This repository has been archived by the owner on Jul 18, 2022. It is now read-only.

Remove prerender test from the test suite #48

Closed
yoavweiss opened this issue Jun 26, 2019 · 4 comments
Closed

Remove prerender test from the test suite #48

yoavweiss opened this issue Jun 26, 2019 · 4 comments
Assignees
Milestone

Comments

@yoavweiss
Copy link
Contributor

No description provided.

@yoavweiss yoavweiss self-assigned this Jun 26, 2019
@toddreifsteck toddreifsteck added this to the Level 2 milestone Aug 1, 2019
@mmocny mmocny mentioned this issue Jul 29, 2020
@mmocny
Copy link

mmocny commented Jul 29, 2020

Looks like this is the test, and I guess the context for removal is that prerender state has been deprecated.

@yoavweiss
Copy link
Contributor Author

Indeed! This has been on my "list of small chores" for ages now...

@mmocny
Copy link

mmocny commented Jul 30, 2020

@yoavweiss are you able to review web-platform-tests/wpt/pull/24802 (should be trivial)?

You're not listed as a suggested_reviewers for page-visibility tests, but according to reviewing-tests apparently "The reviewer can be anyone (other than the original test author) that has the required experience with both the spec under test and with the general test guidelines.", and suggested_reviewers is more of an opt-in for notifications?

yoavweiss pushed a commit to web-platform-tests/wpt that referenced this issue Jul 30, 2020
@yoavweiss
Copy link
Contributor Author

Reviewed and LGTMed! Thank you! :)

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Aug 8, 2020
…s per w3c/page-visibility#48), a=testonly

Automatic update from web-platform-tests
Remove page-visibility prerender test (as per w3c/page-visibility/issues/48) (#24802)

--

wpt-commits: d2f919a0b5328d18bd089ba59280689257a2580d
wpt-pr: 24802
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Aug 15, 2020
…s per w3c/page-visibility#48), a=testonly

Automatic update from web-platform-tests
Remove page-visibility prerender test (as per w3c/page-visibility/issues/48) (#24802)

--

wpt-commits: d2f919a0b5328d18bd089ba59280689257a2580d
wpt-pr: 24802
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Aug 16, 2020
…s per w3c/page-visibility#48), a=testonly

Automatic update from web-platform-tests
Remove page-visibility prerender test (as per w3c/page-visibility/issues/48) (#24802)

--

wpt-commits: d2f919a0b5328d18bd089ba59280689257a2580d
wpt-pr: 24802

UltraBlame original commit: 17f3590132ad54e2c610edec20108196208a0a74
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Aug 16, 2020
…s per w3c/page-visibility#48), a=testonly

Automatic update from web-platform-tests
Remove page-visibility prerender test (as per w3c/page-visibility/issues/48) (#24802)

--

wpt-commits: d2f919a0b5328d18bd089ba59280689257a2580d
wpt-pr: 24802

UltraBlame original commit: 17f3590132ad54e2c610edec20108196208a0a74
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Aug 16, 2020
…s per w3c/page-visibility#48), a=testonly

Automatic update from web-platform-tests
Remove page-visibility prerender test (as per w3c/page-visibility/issues/48) (#24802)

--

wpt-commits: d2f919a0b5328d18bd089ba59280689257a2580d
wpt-pr: 24802

UltraBlame original commit: 17f3590132ad54e2c610edec20108196208a0a74
sidvishnoi pushed a commit to sidvishnoi/gecko-webmonetization that referenced this issue Sep 23, 2020
…s per w3c/page-visibility#48), a=testonly

Automatic update from web-platform-tests
Remove page-visibility prerender test (as per w3c/page-visibility/issues/48) (#24802)

--

wpt-commits: d2f919a0b5328d18bd089ba59280689257a2580d
wpt-pr: 24802
ambroff pushed a commit to ambroff/gecko that referenced this issue Nov 4, 2020
…s per w3c/page-visibility#48), a=testonly

Automatic update from web-platform-tests
Remove page-visibility prerender test (as per w3c/page-visibility/issues/48) (#24802)

--

wpt-commits: d2f919a0b5328d18bd089ba59280689257a2580d
wpt-pr: 24802
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants