Split between OrientationSensor and AbsoluteOrientationSensor #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
index.bs
Outdated
|
|
||
| Inheriting objects can describe the orientation in relation to other stationary | ||
| Other inherited objects can describe the orientation in relation to other stationary |
There was a problem hiding this comment.
Other inherited objects
Other subclasses or inherited interfaces?
index.bs
Outdated
| @@ -11,8 +11,8 @@ Editor: Kenneth Rohde Christiansen 57705, Intel Corporation, http://intel.com/ | |||
| Editor: Anssi Kostiainen 41974, Intel Corporation, http://intel.com/ | |||
| Group: dap | |||
| Abstract: | |||
| This specification defines concrete sensor interfaces to monitor the device's physical | |||
| orientation in relation to <a>Earth's reference coordinate system</a>. | |||
| This specification defines a generic interface and inherited concrete sensor interfaces to monitor the device's | |||
There was a problem hiding this comment.
generic interface and inherited
base orientation sensor interface and concrete sensor subclasses?
pozdnyakov
force-pushed
the
split_OrientationSensor_and_AbsoluteOrientationSensor
branch
from
9b9959b to
609da7c
Compare
alexshalamov
approved these changes
Mar 15, 2017
|
Lgtm |
anssiko
reviewed
Mar 15, 2017
index.bs
Outdated
| The base object describes the orientation in relation to <a>Earth's reference | ||
| coordinate system</a>, thus in a stationary three dimensional Cartesian | ||
| coordinate system. | ||
| The AbsoluteOrientationSensor API inherits from the OrientationSensor API and |
There was a problem hiding this comment.
More clear and consistent with links: {{AbsoluteOrientationSensor}} {{OrientationSensor}}
index.bs
Outdated
|
|
||
| Inheriting objects can describe the orientation in relation to other stationary | ||
| Other subclasses can describe the orientation in relation to other stationary |
index.bs
Outdated
|
|
||
| Inheriting objects can describe the orientation in relation to other stationary | ||
| Other subclasses can describe the orientation in relation to other stationary | ||
| directions, such as true north, or even non stationary directions, like in |
There was a problem hiding this comment.
s/or even/or/
Better be explicit. Reword as needed.
index.bs
Outdated
| directions, such as true north, or even non stationary directions, like in | ||
| relation to a devices own z-position, drifting towards its latest most stable | ||
| z-position. | ||
|
|
||
| The data provided by the OrientationSensor API are similar to data from [=deviceorientation Event=], but the OrientationSensor | ||
| API has some significant differences: | ||
| The data provided by the OrientationSensor-based APIs are similar to data from |
index.bs
Outdated
| 1. Unlike [=deviceorientation Event=] the OrientationSensor API explicitly defines which [=low-level=] motion sensors are used | ||
| to obtain the orientation data, thus obviating possible interoperability issues. | ||
| 1. An {{OrientationSensor}} instance is configurable via {{SensorOptions}} constructor parameter. | ||
| 1. Unlike [=deviceorientation Event=] the OrientationSensor-based APIs explicitly define which [=low-level=] |
pozdnyakov
force-pushed
the
split_OrientationSensor_and_AbsoluteOrientationSensor
branch
from
609da7c to
0f59d02
Compare
|
@anssiko PTAL |
|
LGTM |
pozdnyakov
force-pushed
the
split_OrientationSensor_and_AbsoluteOrientationSensor
branch
from
0f59d02 to
5d602e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As follows from #15
Preview | Diff