Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds appendix with PSK specifications. #296

Merged
merged 9 commits into from
Mar 5, 2023
Merged

Conversation

markafoltz
Copy link
Contributor

@markafoltz markafoltz commented Sep 8, 2022

This addresses Issue #210: [Security] Describe encoding/decoding of PSK into numeric and QR codes.

This appendix describes two ways to turn a PSK, a short pairing code used with SPAKE2, into a visual representation. The first way is as a numeric string in groups of 3 or 4 digits. The other way is with a QR code.

The sample QR code was generated by the following library and was tested on a Pixel phone.

QR-Code-generator

Note, the ISO specification for QR codes does not appear to be in specref, so I will add it as a custom biblio entry.


Preview | Diff

@markafoltz markafoltz requested a review from tidoust September 8, 2022 23:01
@markafoltz markafoltz added the F2F label Sep 8, 2022
Copy link
Member

@tidoust tidoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me with the suggested edits.

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
markafoltz and others added 6 commits March 5, 2023 15:39
Co-authored-by: François Daoust <[email protected]>
Co-authored-by: François Daoust <[email protected]>
Co-authored-by: François Daoust <[email protected]>
Co-authored-by: François Daoust <[email protected]>
Co-authored-by: François Daoust <[email protected]>
@markafoltz
Copy link
Contributor Author

Thanks for the suggested edits @tidoust, I applied them all. Merging.

@markafoltz markafoltz merged commit bbeb6e0 into main Mar 5, 2023
@markafoltz markafoltz deleted the issue-210-psk-encoding branch March 5, 2023 23:53
github-actions bot added a commit that referenced this pull request Mar 5, 2023
SHA: bbeb6e0
Reason: push, by mfoltzgoogle

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants