-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds appendix with PSK specifications. #296
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tidoust
approved these changes
Sep 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good to me with the suggested edits.
Co-authored-by: François Daoust <[email protected]>
Co-authored-by: François Daoust <[email protected]>
Co-authored-by: François Daoust <[email protected]>
Co-authored-by: François Daoust <[email protected]>
Co-authored-by: François Daoust <[email protected]>
Thanks for the suggested edits @tidoust, I applied them all. Merging. |
github-actions bot
added a commit
that referenced
this pull request
Mar 5, 2023
SHA: bbeb6e0 Reason: push, by mfoltzgoogle Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses Issue #210: [Security] Describe encoding/decoding of PSK into numeric and QR codes.
This appendix describes two ways to turn a PSK, a short pairing code used with SPAKE2, into a visual representation. The first way is as a numeric string in groups of 3 or 4 digits. The other way is with a QR code.
The sample QR code was generated by the following library and was tested on a Pixel phone.
QR-Code-generator
Note, the ISO specification for QR codes does not appear to be in specref, so I will add it as a custom biblio entry.
Preview | Diff