Add an algorithm for setting the agent certificate serial number #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Feel free to review now in advance of TPAC. |
|
baylesj@, do you mind taking a look? |
|
PTAL @baylesj I suppose :) |
markafoltz
added
v1-spec
security-tracker
|
Is the same comment not relevant to the |
baylesj
reviewed
Oct 12, 2023
|
The use of |
Yes, that is also an issue, thank you for pointing that out. We won't be able to close Issue #276 until we address that. |
|
PTAL @baylesj, I will have to come up with a separate proposal to fix the subject name. |
|
Went ahead and merged this as comments have been addressed. Please let me know if there are other comments @baylesj |
github-actions bot
added a commit
that referenced
this pull request
Feb 28, 2024
SHA: 21b7b45 Reason: push, by mfoltzgoogle Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses Issue #276: Agent Certificate has a circular dependency on itself
We can't use the certificate fingerprint as the serial number, because the serial number is embedded in the certificate itself.
X.509 requires every certificate from the same issuer to have a unique (not necessarily consecutive) serial number.
This PR adds a simple algorithm to generate a unique per-agent serial number per certificate. Even if an agent generates a new certificate once per hour, the counter would take almost 500,000 years to overflow :-P
Preview | Diff