Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test that ensures fetchStart matches the SW's fetch event start time #148

Closed
yoavweiss opened this issue May 18, 2021 · 1 comment
Closed

Comments

@yoavweiss
Copy link
Contributor

Followup on #143.
We should extend NavigationTiming's SW test to cover matching times.

noamr added a commit to web-platform-tests/wpt that referenced this issue Oct 11, 2021
Mark the timing inside the service worker (and adjust by timeOrigin), to
make sure the timing reported to Navigation Timing correspond with the
milestones specified in
https://w3c.github.io/ServiceWorker/#service-worker-timing.

The four relevant milestones which should be in order:
- PerformanceNavigationTiming.workerStart
- Finish the activation event
- PerformanceNavigationTiming.fetchStart
- Handling the Fetch event in the worker

This is to ensure that the difference between workerStart and fetchStart
measures the delay caused by service worker activation.

See w3c/navigation-timing#148
noamr added a commit to web-platform-tests/wpt that referenced this issue Oct 11, 2021
Mark the timing inside the service worker (and adjust by timeOrigin), to
make sure the timing reported to Navigation Timing correspond with the
milestones specified in
https://w3c.github.io/ServiceWorker/#service-worker-timing.

The four relevant milestones which should be in order:
- PerformanceNavigationTiming.workerStart
- Finish the activation event
- PerformanceNavigationTiming.fetchStart
- Handling the Fetch event in the worker

This is to ensure that the difference between workerStart and fetchStart
measures the delay caused by service worker activation.

See w3c/navigation-timing#148
noamr added a commit to web-platform-tests/wpt that referenced this issue Oct 12, 2021
* [navigation-timing]: Test fine-grained Service Worker timing

Mark the timing inside the service worker (and adjust by timeOrigin), to
make sure the timing reported to Navigation Timing correspond with the
milestones specified in
https://w3c.github.io/ServiceWorker/#service-worker-timing.

The four relevant milestones which should be in order:
- PerformanceNavigationTiming.workerStart
- Finish the activation event
- PerformanceNavigationTiming.fetchStart
- Handling the Fetch event in the worker

This is to ensure that the difference between workerStart and fetchStart
measures the delay caused by service worker activation.

See w3c/navigation-timing#148

* Use step_timeout

* Remove unnecessary timeouts
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Oct 14, 2021
…ervice Worker timing, a=testonly

Automatic update from web-platform-tests
[navigation-timing]: Test fine-grained Service Worker timing (#31187)

* [navigation-timing]: Test fine-grained Service Worker timing

Mark the timing inside the service worker (and adjust by timeOrigin), to
make sure the timing reported to Navigation Timing correspond with the
milestones specified in
https://w3c.github.io/ServiceWorker/#service-worker-timing.

The four relevant milestones which should be in order:
- PerformanceNavigationTiming.workerStart
- Finish the activation event
- PerformanceNavigationTiming.fetchStart
- Handling the Fetch event in the worker

This is to ensure that the difference between workerStart and fetchStart
measures the delay caused by service worker activation.

See w3c/navigation-timing#148

* Use step_timeout

* Remove unnecessary timeouts
--

wpt-commits: 2f8b6be9749e160f9902c9b2f99b00cf7b74b238
wpt-pr: 31187
jamienicol pushed a commit to jamienicol/gecko that referenced this issue Oct 14, 2021
…ervice Worker timing, a=testonly

Automatic update from web-platform-tests
[navigation-timing]: Test fine-grained Service Worker timing (#31187)

* [navigation-timing]: Test fine-grained Service Worker timing

Mark the timing inside the service worker (and adjust by timeOrigin), to
make sure the timing reported to Navigation Timing correspond with the
milestones specified in
https://w3c.github.io/ServiceWorker/#service-worker-timing.

The four relevant milestones which should be in order:
- PerformanceNavigationTiming.workerStart
- Finish the activation event
- PerformanceNavigationTiming.fetchStart
- Handling the Fetch event in the worker

This is to ensure that the difference between workerStart and fetchStart
measures the delay caused by service worker activation.

See w3c/navigation-timing#148

* Use step_timeout

* Remove unnecessary timeouts
--

wpt-commits: 2f8b6be9749e160f9902c9b2f99b00cf7b74b238
wpt-pr: 31187
@noamr
Copy link
Contributor

noamr commented Nov 9, 2021

Done

@noamr noamr closed this as completed Nov 9, 2021
Gabisampaio pushed a commit to Gabisampaio/wpt that referenced this issue Nov 18, 2021
…tform-tests#31187)

* [navigation-timing]: Test fine-grained Service Worker timing

Mark the timing inside the service worker (and adjust by timeOrigin), to
make sure the timing reported to Navigation Timing correspond with the
milestones specified in
https://w3c.github.io/ServiceWorker/#service-worker-timing.

The four relevant milestones which should be in order:
- PerformanceNavigationTiming.workerStart
- Finish the activation event
- PerformanceNavigationTiming.fetchStart
- Handling the Fetch event in the worker

This is to ensure that the difference between workerStart and fetchStart
measures the delay caused by service worker activation.

See w3c/navigation-timing#148

* Use step_timeout

* Remove unnecessary timeouts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants