chore: cleanup bikeshed usage #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoscaceres
commented
Jan 19, 2024
marcoscaceres
commented
Jan 19, 2024
chrisn
approved these changes
Jan 19, 2024
|
I am not a big fan of full style rewrites, but since it is there, let's do it. |
youennf
reviewed
Jan 22, 2024
| @@ -829,14 +769,14 @@ interface MediaSession { | |||
| <p> | |||
| The <dfn attribute for="MediaSession"><code>playbackState</code></dfn> | |||
| attribute represents the <dfn>declared playback state</dfn> of the <a>media | |||
| session</a>, by which the session declares whether its <a>browsing context</a> | |||
| session</a>, by which the session declares whether its [=/browsing context=] | |||
There was a problem hiding this comment.
Out of curiosity, why [=/ instead of [= ?
There was a problem hiding this comment.
Oops, sorry I missed this @youennf ... I think bikeshed likes an explicit "/" null "for context", because "browsing context" context can be ambiguous:
youennf
approved these changes
Jan 22, 2024
|
hehe, looks like no one has called |
github-actions bot
added a commit
that referenced
this pull request
Apr 14, 2024
SHA: 52acdd4 Reason: push, by marcoscaceres Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some unnecessary hard links, removes some redundant text ... other little fixes.
Preview | Diff