Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add position state to the spec #210

Merged
merged 1 commit into from
May 2, 2019
Merged

Add position state to the spec #210

merged 1 commit into from
May 2, 2019

Conversation

beccahughes
Copy link
Contributor

@beccahughes beccahughes commented Mar 12, 2019 •
edited by pr-preview bot
Loading

@beccahughes beccahughes mentioned this pull request Mar 12, 2019
Closed
@mounirlamouri
Copy link
Member

@beaufortfrancois can you PTAL?

calvaris
calvaris reviewed Mar 20, 2019
View reviewed changes
index.bs Outdated Show resolved Hide resolved
beaufortfrancois
beaufortfrancois reviewed Mar 20, 2019
View reviewed changes
index.bs Show resolved Hide resolved
index.bs Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
@beccahughes beccahughes force-pushed the position branch 2 times, most recently from 2203565 to 7b4f716 Compare March 20, 2019 18:28
beaufortfrancois
beaufortfrancois reviewed Mar 21, 2019
View reviewed changes
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
@beccahughes
Copy link
Contributor Author

Does anyone have any more feedback or can I go ahead and merge this?

mounirlamouri
mounirlamouri reviewed Apr 5, 2019
View reviewed changes
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
@beccahughes beccahughes force-pushed the position branch 3 times, most recently from e2a1355 to 44448ec Compare April 12, 2019 18:31
mounirlamouri
mounirlamouri approved these changes May 2, 2019
View reviewed changes
Copy link
Member

@mounirlamouri mounirlamouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with comments applied

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
@beccahughes beccahughes merged commit c8232c9 into w3c:master May 2, 2019
@beccahughes beccahughes deleted the position branch May 2, 2019 23:10
@beccahughes beccahughes mentioned this pull request Jul 29, 2019
Closed
@MattiasBuelens MattiasBuelens mentioned this pull request Sep 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvaris calvaris calvaris left review comments

@beaufortfrancois beaufortfrancois beaufortfrancois left review comments

@mounirlamouri mounirlamouri mounirlamouri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@beccahughes @mounirlamouri @beaufortfrancois @calvaris