Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to constructor operations #235

Closed
ChunMinChang opened this issue Sep 16, 2019 · 2 comments
Closed

Update to constructor operations #235

ChunMinChang opened this issue Sep 16, 2019 · 2 comments

Comments

@ChunMinChang
Copy link
Member

ChunMinChang commented Sep 16, 2019 •
edited
Loading 

[Constructor(optional MediaMetadataInit init), Exposed=Window]
interface MediaMetadata {
  ...
};

should be replaced by

[Exposed=Window]
interface MediaMetadata {
  constructor(optional MediaMetadataInit init);
  ...
};

since the syntax is changed in whatwg/webidl#778.
@ChunMinChang
Copy link
Member Author

Not sure if the editors are working on this or not. I can submit a request if no one is working on this.

ChunMinChang added a commit to ChunMinChang/mediasession that referenced this issue Sep 17, 2019
@ChunMinChang
Use new constructor() syntax
e73b8b0 
This solves w3c#235
@ChunMinChang ChunMinChang mentioned this issue Sep 17, 2019
Merged
@ChunMinChang ChunMinChang changed the title Use new constructor() syntax Update to constructor operations Sep 18, 2019
@ChunMinChang ChunMinChang mentioned this issue Sep 19, 2019
Closed
mounirlamouri pushed a commit that referenced this issue Sep 20, 2019
@ChunMinChang @mounirlamouri
Use new constructor() syntax (#236)
998ff76 
* Use new constructor() syntax

This solves #235

* Give default value for MediaMetadata constructor

This solves #238
@ChunMinChang
Copy link
Member Author

Fixed in #236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ChunMinChang