Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'originIdentifier' in getUserMedia() steps (issue #339) #349

Merged
merged 2 commits into from
May 12, 2016

Conversation

adam-be
Copy link
Member

@adam-be adam-be commented Apr 25, 2016

Fix for issue #339

First commit is purely editorial so please review the second.

to have permission status "granted", resulting in a set of
provided media.</p>
<p>For the origin identified by <var>originIdentifier</var>,
<a>request permission</a> for use of the devices, while
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see how we're expected to verify anything about a "request permission" algorithm that doesn't exist yet.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it's not in the TR which is what we link to, and we still have a disclaimer in our doc saying it doesn't exist. The link then seems like it should be _request a permission, not _request permission.

Also, maybe everyone else is aware, but this surprised me, that the other spec seems to follow a slightly different process for consensus than at least I was used to. Specifically, the editor of the other spec says he doesn't "claim that the current text represents any sort of consensus."

I'm surprised we're adding such dependencies when we're supposed to be way past last call.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way in this spec now for getUserMedia to succeed without granting persistent permission? What does _request a permission_ return in that case?

See #350 for my take down of the request permission algorithm.

@adam-be
Copy link
Member Author

adam-be commented Apr 27, 2016

@jan-ivar, my interpretation is that your concerns are mainly with text that's not added by this PR (that you've also created a new issue for). And that shouldn't block us from merging this PR. Is that correct?

Edit: Note that first commit is fixing indentation (mix of spaces and tabs), and the actual change is in the second commit.

@jan-ivar
Copy link
Member

@adam-be Sounds like the algorithm referenced should be request _a_ permission, though I see no evidence that it takes an origin (though the document does talk about origin elsewhere now).

The level of meaninglessness seems neither increased nor diminished by this PR, so I have no problem with it merging.

@alvestrand alvestrand merged commit eb06722 into w3c:master May 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants