Skip to content
This repository has been archived by the owner on Jul 30, 2019. It is now read-only.

only select browsing context by name within unit of related... #1406

Merged
merged 5 commits into from
Apr 25, 2018

Conversation

chaals
Copy link
Collaborator

@chaals chaals commented Apr 24, 2018

First cut at matching Firefox/Chrome implementation
fix #262

First cut at matching Firefox/Chrome implementation
fix #262
@chaals chaals requested a review from siusin April 24, 2018 15:07
@chaals
Copy link
Collaborator Author

chaals commented Apr 24, 2018

cc @0x1a0ran

Copy link
Contributor

@siusin siusin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes make sense to me, except for two minor editorial bugs.

Thanks!

Trey Shugart,
"Unor", <!-- on github -->
"wallabag.it", <!-- twitter -->
William Chen,
Wolfgang Illmeyer,
Xioran Wang,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Xioran/Xiaoran

@@ -13,6 +13,9 @@
<h3 id="changes-wd3">Changes since the <a href="https://www.w3.org/TR/2017/WD-html53-20170206/">HTML 5.3 Second Public Working Draft</a></h3>

<dl>
<dt><a href="https://github.com/w3c/html/pull/1406">Only elect a browsing context by name</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/elect/select

chaals added 3 commits April 25, 2018 15:49
It's good to get people's names right when thanking them.
(although either way made sense, fixing it gives the intended text)
@siusin siusin merged commit 569d7d6 into master Apr 25, 2018
plehegar pushed a commit that referenced this pull request Apr 25, 2018
@chaals chaals deleted the chaals-choosing-browcon-by-name-262 branch April 25, 2018 14:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

window.open(url, name) is vulnerable to XSS with "name" collision
2 participants