This repository has been archived by the owner on Jul 30, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 550
only select browsing context by name within unit of related... #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First cut at matching Firefox/Chrome implementation fix #262
cc @0x1a0ran |
siusin
suggested changes
Apr 25, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes make sense to me, except for two minor editorial bugs.
Thanks!
sections/acknowledgements.include
Outdated
Trey Shugart, | ||
"Unor", <!-- on github --> | ||
"wallabag.it", <!-- twitter --> | ||
William Chen, | ||
Wolfgang Illmeyer, | ||
Xioran Wang, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/Xioran/Xiaoran
sections/changes.include
Outdated
@@ -13,6 +13,9 @@ | |||
<h3 id="changes-wd3">Changes since the <a href="https://www.w3.org/TR/2017/WD-html53-20170206/">HTML 5.3 Second Public Working Draft</a></h3> | |||
|
|||
<dl> | |||
<dt><a href="https://github.com/w3c/html/pull/1406">Only elect a browsing context by name</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/elect/select
It's good to get people's names right when thanking them.
siusin
approved these changes
Apr 25, 2018
plehegar
pushed a commit
that referenced
this pull request
Apr 25, 2018
…in unit of related... (#1406)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First cut at matching Firefox/Chrome implementation
fix #262