Skip to content
This repository has been archived by the owner on Jul 30, 2019. It is now read-only.

Commit

Permalink
Focus the dialog instead of the first item (#1331)
Browse files Browse the repository at this point in the history
fix #773
* Fixed Dialog Focus according to issue 773
* marked as potentially at risk
  • Loading branch information
patricia-gallardo authored and chaals committed Apr 17, 2018
1 parent 3f3b669 commit 2a10df5
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 5 deletions.
3 changes: 2 additions & 1 deletion includes/status.include
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ will be not be included in a Proposed Recommendation,
per [W3C Process - 6.4 Candidate Recommendation](https://www.w3.org/2017/Process-20170301/#candidate-rec):</p>

<ul>
<li>the <{input/autocapitalize}> attribute;</li>
<li>the <{autocapitalize}> attribute;</li>
<li>focusing the dialog instead of the first focusable element if there are no autofocus elements, see issue 773</li>
<li>the <{media/disableRemotePlayback}> attribute;</li>
<li>{{registerContentHandler()}}, {{unregisterContentHandler()}} and {{isContentHandlerRegistered()}} methods;</li>
<li><a>customized built-in elements</a> and the <{global/is}> attribute</li>
Expand Down
13 changes: 13 additions & 0 deletions sections/acknowledgements.include
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,11 @@
"adugamayuba", <!-- on github -->
Ajay Data,
Alex Danilo,
Alexander Surkov,
Alex Komoroske,
Alex Russell,
Alexandre Borela,
Alastair Campbell,
Amelia Bellamy-Royds,
Andrea Rendine,
Andres Rios,
Expand All @@ -55,12 +57,15 @@
Chris Harvey,
Chris Rebert,
Collin Anderson,
Dan Beam,
Daniel Buchner,
David Hyatt,
David Singer,
Darryl Pogue,
"Decaid", <!-- on github -->
Derek Gray,
Devarshi Pant,
Dominic Mazzoni,
Diego Ferreiro Val,
Dimitri Glazkov,
Dominic Cooney,
Expand All @@ -70,9 +75,12 @@
Eric Bailey,
Erik Arvidsson,
Fabian Pijcke,
freshp86, <!-- on github -->
Hajime Morrita,
Hayato Ito,
Heydon Pickering,
J.C.Jones,
James Craig,
Jan Miksovsky,
Jimmy Bosse,
"Jinjiang 勾三股四", <!-- github -->
Expand All @@ -85,14 +93,17 @@
Jonathan T Neal,
Jothan Frake,
Justin Falgani,
田村健人 (TAMURA Kent),
Koji Ishii,
Leif Halvard Silli,
Léonie Watson,
Lea Verou,
Maciej Stachowiak,
Marco Zehe,
Mark Svancarek,
Martin Janecke,
Marvin Woo 吴秀诚,
Matt Falkenhagen,
Mike™ Smith,
Mike West,
"Miketubby", <!-- github -->
Expand Down Expand Up @@ -120,6 +131,7 @@
Ronald Eddy jr.,
Ryosuke Niwa,
Sailesh Panchang,
Sam Thorogood,
Scott Miles,
"SelenIT", <!-- github -->
Shawn Steele,
Expand All @@ -128,6 +140,7 @@
Steven Faulkner,
Steven Skelton,
Tab Atkins,
Takayoshi Kochi,
Theresa O'Connor,
Tim Perry,
Todor Todorov,
Expand Down
5 changes: 5 additions & 0 deletions sections/changes.include
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,11 @@
Fixed <a href="https://github.com/w3c/html/issues/1217">issue 1217</a>
</dd>
<dt>
<a href="https://github.com/w3c/html/pull/1331">Focusing the dialog instead of the first focusable element if there are no autofocus elements</a>
</dt>
<dd>
Substantive change. Fixes <a href="https://github.com/w3c/html/issues/773">issue 773</a>. Potentially at risk.
</dt>
<a href="https://github.com/w3c/html/pull/1332">Clarify that the DOCTYPE is ignored, if present, for srcdoc</a>
</dt>
<dd>
Expand Down
5 changes: 1 addition & 4 deletions sections/semantics-interactive-elements.include
Original file line number Diff line number Diff line change
Expand Up @@ -663,10 +663,7 @@
Let <var>control</var> be the first non-<a>inert</a> <a>focusable area</a> in
<var>subject</var>'s <a>control group</a> whose <a>DOM anchor</a> has an <{formelements/autofocus}> attribute specified.

If there isn't one, then let <var>control</var> be the first non-<a>inert</a>
<a>focusable area</a> in <var>subject</var>'s <a>control group</a>.

If there isn't one of those either, then let <var>control</var> be <var>subject</var>.
If there isn't one, then let <var>control</var> be <var>subject</var>.

</li>

Expand Down

0 comments on commit 2a10df5

Please sign in to comment.