Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate html elements and attributes into different tables #262

Merged
merged 12 commits into from
Feb 24, 2021

Conversation

scottaohara
Copy link
Member

@scottaohara scottaohara commented Feb 18, 2021

Treat these tables separately so we can be more clear with guidance specific to roles vs attributes.

adds in new specific attribute call outs on elements such as checkbox, radio, options and selects which should not have specific aria-* attributes set.

revised/re-explained allowances for specific html attributes and their implicit aria attribute semantics are in the new second table.

This PR will close #122, #225 and #241


Preview | Diff

@scottaohara
Copy link
Member Author

scottaohara commented Feb 19, 2021

edit: scratching the note I had here. needs to be thought out more and i want to run some tests.

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Show resolved Hide resolved
additional wording updates / descriptions of the tables to accommodate for the splitting of the element/attributes into two tables
Copy link
Member

@patrickhlauke patrickhlauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would still be good to make the change to the other tables to start rows with a <th> rather than just having that for the one new table?

@patrickhlauke
Copy link
Member

Would still be good to make the change to the other tables to start rows with a <th> rather than just having that for the one new table?

happy to try and make a semi-clever find/replace for this if you want, @scottaohara

@scottaohara
Copy link
Member Author

@patrickhlauke i wouldn't mind but for the fact I have other PRs that may have unnecessary merge conflicts if we go doing that here. I'd rather just get this and the other PRs merged in, and then this can easily be done.

@patrickhlauke
Copy link
Member

@patrickhlauke i wouldn't mind but for the fact I have other PRs that may have unnecessary merge conflicts if we go doing that here. I'd rather just get this and the other PRs merged in, and then this can easily be done.

ok makes sense. i opened a separate issue to track this. so with that out of the way, i think this is good to go

@stevefaulkner stevefaulkner merged commit d382ab9 into gh-pages Feb 24, 2021
@scottaohara scottaohara deleted the attribute-updates branch February 24, 2021 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider to clarify aria-disabled usage
4 participants