-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates to custom elements #210
Conversation
Updates autonomous custom elements and form associated custom elements to indicate that they have no corresponding role if an author did not define a role in the custom element’s `ElementInternals`. The allowed roles and properties column has been updated to indicate that if a custom element has an author defined role, then the allowed roles to that element must be in adherence to the defined role.
Co-Authored-By: Carolyn MacLeod <[email protected]>
Co-Authored-By: Carolyn MacLeod <[email protected]>
Looks good. |
yes, no references presently. we should make them |
whatwg/html#4658 was merged. |
Also w3c/aria#984 was merged. So I think the "not ready for merge" label can be removed now. |
Closes #180
Updates autonomous custom elements and form associated custom elements to indicate that they have no corresponding role if an author did not define a role in the custom element’s
ElementInternals
.The allowed roles and properties column has been updated to indicate that if a custom element has an author defined role, then the allowed roles to that element must adhere to the defined role of the custom element.
I'm thinking it's probably a good idea to add an example, at the end of section 2, to help demonstrate proper conformance here.
e.g.
<my-element>
with no role defined from itsElementInternals
can accept any role.but if
<my-check>
were created and had its role defined via its internals...(example from the pending PR to the HTML spec)
Then only roles allowed on a checkbox would be allowed on this custom element.
That all said, we shouldn't merge this update until the linked HTML and ARIA issues in #180 are merged.
cc @carmacleod
Preview | Diff